Add support for buttons on Inky Impression#48
Merged
Conversation
lawik
reviewed
Aug 1, 2022
lawik
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, added a question :)
| The Inky Impression has 4 buttons that are monitored independently from the display | ||
| and can be started in supervison. | ||
|
|
||
| Supply the `:handler` option as either a pid, or `{module, function, args}` tuple |
Collaborator
There was a problem hiding this comment.
Would it make sense to also support an atom name for a process? I think that'd be convenient considering these are all likely singletons.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Luckily, the buttons for the impression are the same as those on the Unicorn Hat, so I was able to pull in the same code, which coincidentally is the same as the button code for the Scroll Hat.
I think Pimoroni must have planned for their devices to use the same pins for buttons. How convenient :)