Conversation
…file reads The parallel hash workers discarded the result of fetch_range_with_predicate, so a read error or a static file that did not cover the requested range silently produced fewer hashes, and the transaction lookup stage indexed the range as complete. Errors are now forwarded through the channel and a result that is shorter than the requested range is reported as a missing static file transaction.
0xShadowX
force-pushed
the
fix/tx-hashes-range-complete
branch
from
September 20, 2026 09:05
56dc23b to
49c0eb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parallel hash workers in
StaticFileProvider::transaction_hashes_by_rangediscarded the result offetch_range_with_predicate, so a read error or a static file that did not cover the requested range silently produced fewer hashes than requested. The transaction lookup stage does not verify the count and indexed such a range as complete, leaving the missing hashes without aTransactionHashNumbersentry.Errors are now forwarded through the channel, and a result that is shorter than the requested range is reported as a missing static file transaction so the caller can retry instead of committing a partial index.