Conversation
The dynamic NAT resolvers (any, upnp, publicip, netif) were only ever run by the discv4 service, so a node with discv4 disabled and the default --nat any never resolved its external ip. Its discv5 ENR only learned the ip from peer votes, and until then admin_nodeInfo and the local enode advertised 127.0.0.1. The discovery service now runs the resolver itself when discv4 is disabled and applies the resolved ip to the local discv5 ENR, using the same interval as discv4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27279
Runs periodic NAT resolution for discv5-only nodes so their local ENR and node info advertise the resolved external IP without waiting for peer votes. Updates preserve advertised ports and configured address families, and resolution stays disabled when no discovery protocol is running.
Network interface lookup and HTTP client setup run on blocking workers so discovery polling does not block the network loop.