Conversation
The subscription was accepted before its params were checked, so a request
such as eth_subscribe("logs", true) received a subscription id and the
invalid params error was dropped inside the spawned task, leaving the client
with a subscription that never delivers anything. Params are now validated
first and invalid requests are rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eth_subscribeaccepted the subscription before its params were checked, so a request such aseth_subscribe("logs", true)received a subscription id while the invalid params error was dropped inside the spawned task, leaving the client with a subscription that never delivers anything. The same happened fornewPendingTransactionsandtransactionReceiptswith params of the wrong shape.The params are now validated per subscription kind before the subscription is accepted, and invalid requests are rejected with an invalid params error; the handlers reuse the same helpers.