Return True when there are no user backends during shutdown - #3724
Open
zhiqiangwang08 wants to merge 4 commits into
Open
zhiqiangwang08 wants to merge 4 commits into
zhiqiangwang08 wants to merge 4 commits into
Conversation
zhiqiangwang08
requested review from
CyberDem0n and
hughcapet
as code owners
September 18, 2026 23:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When PostgreSQL has no user backends,
wait_for_user_backends_to_close()implicitly returnsNone, so_do_stop()skips the earlyon_safepointcallback. The watchdog can remain armed while PostgreSQL completes its remaining shutdown work.Return
Trueexplicitly for the empty-backend case, as documented. Keep the existing behavior for active backends, timeouts, and failures to retrieve child processes unchanged.Add regression coverage for empty child lists and auxiliary-only/disappeared children, with and without a timeout. Also verify that the safepoint callback runs before waiting for the postmaster to exit, and clarify this behavior in the watchdog documentation.
Fixes #3723.
Validation on Windows / Python 3.12:
pytest tests --doctest-modules patroni): 754 passed, 17 skipped, 39 subtests passed.flake8 patroni tests setup.py): passed.git diff --check: passed.Linux watchdog and PostgreSQL/DCS integration scenarios have not been run locally.