Conversation
added 2 commits
October 23, 2022 15:20
Contributor
Author
|
closes #30 |
pberkes
requested changes
Oct 24, 2022
Owner
pberkes
left a comment
There was a problem hiding this comment.
Thank you for your submission, I have a few comments and change requests
Contributor
Author
|
@pberkes Have made the requested changes! Do review and let me know. Thanks |
pberkes
requested changes
Oct 28, 2022
Contributor
Author
|
Unit test added to check report even if big_o is called in verbose mode. |
Owner
good idea |
pberkes
approved these changes
Oct 28, 2022
Owner
|
Thank you! LGTM |
Contributor
Author
|
Thanks & sorry about the long discussions. Just getting started with Open Source! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30Description
Check List (Check all the applicable boxes)
Screenshots
Call method
Functionality can be invoked by calling big_o.print_report(best, others)