Skip to content

Report generation#54

Merged
pberkes merged 14 commits into
pberkes:masterfrom
harisaisundhar:report_gen
Oct 28, 2022
Merged

Report generation#54
pberkes merged 14 commits into
pberkes:masterfrom
harisaisundhar:report_gen

Conversation

@harisaisundhar

@harisaisundhar harisaisundhar commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Closes #30

Description

  • Report generation functionality drafted
  • Consists of displaying the best complexity along with the scores of other others
  • Report sorted based on the residual time
  • Output printed in the format of a table

Check List (Check all the applicable boxes)

  • I understand that my contributions needs to pass the checks.
  • If I created new functions / methods, I documented them and add type hints.
  • If I modified already existing code, I updated the documentation accordingly.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2022-10-23 at 4 15 57 PM

Call method

Functionality can be invoked by calling big_o.print_report(best, others)

@harisaisundhar

Copy link
Copy Markdown
Contributor Author

closes #30

@pberkes pberkes left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission, I have a few comments and change requests

Comment thread README.rst Outdated
Comment thread README.rst Outdated
Comment thread big_o/big_o.py Outdated
Comment thread big_o/big_o.py Outdated
Comment thread big_o/big_o.py Outdated
Comment thread big_o/big_o.py Outdated
Comment thread big_o/big_o.py Outdated
Comment thread big_o/big_o.py Outdated
Comment thread README.rst Outdated
@harisaisundhar

Copy link
Copy Markdown
Contributor Author

@pberkes Have made the requested changes! Do review and let me know. Thanks

Comment thread big_o/__init__.py Outdated
Comment thread big_o/test/test_reports.py Outdated
Comment thread big_o/test/test_reports.py Outdated
Comment thread big_o/reports.py Outdated
Comment thread README.rst Outdated
@harisaisundhar

Copy link
Copy Markdown
Contributor Author

Unit test added to check report even if big_o is called in verbose mode.

@pberkes

pberkes commented Oct 28, 2022

Copy link
Copy Markdown
Owner

Unit test added to check report even if big_o is called in verbose mode.

good idea

@pberkes

pberkes commented Oct 28, 2022

Copy link
Copy Markdown
Owner

Thank you! LGTM

@pberkes pberkes merged commit d700425 into pberkes:master Oct 28, 2022
@harisaisundhar

Copy link
Copy Markdown
Contributor Author

Thanks & sorry about the long discussions. Just getting started with Open Source!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants