✨ Export selected objects with saved presets - #11809
Open
minwookshin wants to merge 4 commits into
Open
minwookshin wants to merge 4 commits into
minwookshin wants to merge 4 commits into
Conversation
Add a discoverable File menu command and remappable shortcut for direct selection export. Reuse the existing export pipeline and notifications, reserve pending batch jobs, and preserve each transport's naming contract. Cover selection, lifecycle, retries, and WASM filenames with regression tests alongside the existing frontend suite. AI-assisted-by: gpt-6 Signed-off-by: Minwook Shin <163576506+minwookshin@users.noreply.github.com>
Contributor
|
Thanks for your contribution! We've received your pull request and assigned it for review. It may take us a little while to get to it, but we appreciate your patience and will be in touch as soon as we can! A quick note: we welcome responsible use of AI tools, but please make sure any AI-assisted contributions are carefully reviewed by a human before submitting. PRs that don't meet our quality standards may be closed without detailed review. |
Keep upstream catalog additions alongside the five export messages. The reviewed export implementation and regression tests are unchanged. Verify the merged frontend: 988 tests and 3,384 assertions pass. AI-assisted-by: gpt-6 Signed-off-by: Minwook Shin <163576506+minwookshin@users.noreply.github.com>
Keep the export-selection and upstream SVG upload test registrations. The generated files and translations from both branches are preserved. AI-assisted-by: GPT-6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR was prepared with Codex assistance and reviewed by the submitting contributor.
What
Add Export selection to the native File menu and existing remappable shortcut system (proposed default: Cmd/Ctrl+Alt+Shift+E), using selected objects' saved export settings. Closes #11682.
Why
Repeated selected-object exports currently require opening and confirming the export dialog. A direct action should preserve scope and format preferences, including when selection is empty or only partly configured.
How
Verification
The initial feature head passed the full frontend suite: 988 tests / 3,384 assertions, zero failures or errors, modified-file formatting/lint, a real WASM build, and complete main/worker compilation.
The latest merge of
develop(267134e) preserves both export-selection and upstream SVG-upload test registrations. The four feature source files and both export test files are unchanged from the published contribution. The portable selection suite passed 10 tests / 22 assertions, and runner lint/format and namespace/translation preservation checks passed. The full CLJS/WASM/browser suites were not rerun for this merge.The compiled editor with repository document/profile fixtures downloaded a real
Board 1@2x.pngat 380 × 400 from both menu and shortcut. Existing dialog, missing settings and empty selection behavior were inspected. Real-store tests cover duplicate requests, batch failure/retry, unchanged document data and all five WASM filename formats.A deployed exporter cluster, physical devices and screen readers were not tested. Command naming/default shortcut and mixed-selection policy are proposed for maintainer discussion.
Screenshots
The compiled editor uses repository document/profile fixtures and the real WASM renderer.
Native File menu with the new command and shortcut:
The existing export dialog remains available:
Actual exported Board 1@2x.png (380 × 400)