Skip to content

CP-17546 resultset transaction - #17593

Merged
niden merged 6 commits into
5.0.xfrom
CP-17546-resultset-transaction
Sep 17, 2026
Merged

niden merged 6 commits into
5.0.xfrom
CP-17546-resultset-transaction

Conversation

@niden

@niden niden commented Sep 17, 2026

Copy link
Copy Markdown
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

  • Phalcon\Db\Adapter\Pdo\AbstractPdo::commit() and rollback() now throw Phalcon\Db\Exceptions\NoActiveTransaction when the connection has no active transaction, instead of sending a commit, rollback or savepoint statement to the server.
  • Fixed Phalcon\Db\Adapter\Pdo\AbstractPdo leaving the transaction nesting level wrong when begin(), commit() or rollback() fails.

Thanks

@niden
niden requested a review from Jeckerson September 17, 2026 16:55
@niden niden self-assigned this Sep 17, 2026
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Sep 17, 2026
Assisted-by: Claude Code
@niden
niden merged commit b54b4d3 into 5.0.x Sep 17, 2026
352 of 354 checks passed
@niden
niden deleted the CP-17546-resultset-transaction branch September 17, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant