fix: decode binary UUID IDs correctly; add CSUUID/JUUID display formats#7
Merged
Conversation
lazydonkeytim
commented
May 11, 2026
Collaborator
- Rewrite binaryToCanonicalUuid to handle both plain EJSON objects and BSON Binary class instances (fixes garbled chars in drawer header)
- extractIdString now decodes subType 03 as CSUUID instead of falling through to String(binaryInstance)
- Add formatDocumentId() used in DocumentEditor header, respects the global uuidFormat setting
- Add 'csuuid' and 'juuid' to UuidFormat; update formatUuid/isBsonUuid
- Settings menu: CSUUID (.NET / C#), JUUID (Java) display options
- Server: buildIdCandidates tries subType 03 CSUUID + JUUID byte orders so Update/Delete work for legacy .NET binary IDs
- matchesId accepts both CSUUID-decoded and standard-order UUID strings for subType 03 Binary values
- Rewrite binaryToCanonicalUuid to handle both plain EJSON objects and BSON Binary class instances (fixes garbled chars in drawer header) - extractIdString now decodes subType 03 as CSUUID instead of falling through to String(binaryInstance) - Add formatDocumentId() used in DocumentEditor header, respects the global uuidFormat setting - Add 'csuuid' and 'juuid' to UuidFormat; update formatUuid/isBsonUuid - Settings menu: CSUUID (.NET / C#), JUUID (Java) display options - Server: buildIdCandidates tries subType 03 CSUUID + JUUID byte orders so Update/Delete work for legacy .NET binary IDs - matchesId accepts both CSUUID-decoded and standard-order UUID strings for subType 03 Binary values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.