Repository navigation
Clean up filesystem function signatures - #931
Conversation
14e51ca to
f63c44d
Compare
|
I'm pretty sure I got all mismatched signatures, if I missed any let me know. 👍 |
|
I'm surprised this isn't caught by #903, @kocsismate any idea why? |
Yes, I only added a subset of all the changes, and I left most of the functions in ext/standard untouched until the majority of my outstanding PRs are merged. |
|
Okay that explains that then. :-) |
Girgias
left a comment
There was a problem hiding this comment.
I haven't marked all the union type issues as it is a recurrent issue.
The var name changes in the examples are dubious IMHO.
Girgias
left a comment
There was a problem hiding this comment.
Still the minor complaint about using $fp but that's fine.
kocsismate
left a comment
There was a problem hiding this comment.
A few nits. Please fix these, and then finally we can merge this PR :)
Co-authored-by: Máté Kocsis <kocsismate@woohoolabs.com>
kocsismate
left a comment
There was a problem hiding this comment.
I'm going to merge this tomorrow, unless someone else spots any new issues.
This PR intends to clean up the function signatures for the filesystem functions. Some are missing default initializers, mostly the nullable parameters, and some have missing return types.
copythough for instance had the wrong parameter names, in the documentation, they are$sourceand$destrespectively but the actual names - found in the php-src, are$fromand$to.This PR will be squashed down to one commit before it is ready to merge.