Repository navigation
GREP_HEADER() is broken #16199
Description
Description
Hi,
testing compilation on MSVC (vs17 x64) of PHP 8.4.0RC1 configure --with-openssl-argon2 with openssl 3.3.2
- had the error:
Enabling extension ext\openssl [shared]
Checking for OSSL_set_max_threads in openssl/thread.h ...
Checking for openssl/thread.h ... <not found>
Checking for openssl/thread.h ... C:\sdk\release\vs17_x64-avx2\_openssl\openssl\include
Problem reading C:\sdk\release\vs17_x64-avx2\_openssl\openssl\include
No
WARNING: OpenSSL argon2 hashing requires OpenSSL >= 3.2
- checked all the stuff on openssl part : no problem
- looked why the message
Problem reading C:\sdk\release\vs17_x64-avx2\_openssl\openssl\includedidn't include the filename and realize thatGREP_HEADERin/win32/build/confutils.jsis buggy:
header_nameis only appended infile_get_contents()param whenpath_to_check()is set and not when path come fromsearch_paths()result.
- here is a working path
--- a/win32/build/confutils.js
+++ b/win32/build/confutils.js
@@ -968,11 +968,11 @@ function GREP_HEADER(header_name, regex, path_to_check)
var p = search_paths(header_name, path_to_check, "INCLUDE");
if (typeof(p) == "string") {
- c = file_get_contents(p);
+ c = file_get_contents(p+ "\\" + header_name);
} else if (p == false) {
p = search_paths(header_name, PHP_EXTRA_INCLUDES, null);
if (typeof(p) == "string") {
- c = file_get_contents(p);
+ c = file_get_contents(p+ "\\" + header_name);
}
}
if (!c) {- configure log after patch
Enabling extension ext\openssl [shared]
Checking for OSSL_set_max_threads in openssl/thread.h ...
Checking for openssl/thread.h ... <not found>
Checking for openssl/thread.h ... C:\sdk\release\vs17_x64-avx2\_openssl\openssl\include
OK
Note: Don't know where the useless No and OK message line come from... might be removed
PHP Version
PHP 8.4.0RC1
Operating System
Win11
Activity
cmb69 commentedon Oct 3, 2024
Thank you. See also #15619.
Only when
search_paths()is called, you get<in default path>/<not found>; otherwise you getSo removing
OK/Noneeds more adjustments. I don't think this output is a real problem, though.nono303 commentedon Oct 3, 2024
Thx @cmb69!
This output is not a problem,
I just didn't understand where it came from (and that also explain some
\nissue during the search_paths sequence)[-]bug on GREP_HEADER in /win32/build/confutils.js[/-][+]GREP_HEADER() is broken[/+]Fix GH-16199: GREP_HEADER() is broken
Merge branch 'PHP-8.4'