Repository navigation
array_sum() with GMP can loose precision (LLP64) #16890
Description
Description
The following code:
<?php
var_dump(array_sum([new GMP("9223372036854775806"), 1]));Resulted in this output:
float(9.223372036854775E+18)
But I expected this output instead:
int(9223372036854775807)
This is caused by an erroneous assumption in gmp_cast_object() for _IS_NUMBER casts (as such it can affect other functions as well), namely that ZEND_LONG would be a signed long, but that is not true for LLP64 data models where it is signed long long. On such platforms, values outside of range [INT_MIN, INT_MAX] are converted to float.
PHP Version
PHP-8.2
Operating System
Windows 64bit
Activity
cmb69 commentedon Nov 21, 2024
Oops. In the meantime I've noticed that
array_sum()in PHP-8.2 is not affected by this (since objects are skipped); so the given reproducer does not apply. Still, the issue should be fixed in PHP-8.2, too, since it may affect external extensions. I don't think the bug could be triggered using SimpleXML, which is the only other extension usingconvert_scalar_to_number()in php-src.Fix phpGH-16890: array_sum() with GMP can loose precision (LLP64)
Merge branch 'PHP-8.3' into PHP-8.4
Merge branch 'PHP-8.4'
Fix GH-16890: array_sum() with GMP can loose precision (LLP64)