Assertion failure in array_shift with self-referencing array #16957

Activity

1. YuanchengJiang

   added

   Bug

   Status: Needs Triage

   on Nov 27, 2024
2. devnexen

   added

   Extension: standard

   Status: Verified

   and removed

   Status: Needs Triage

   on Nov 27, 2024
3. ndossche commented on Nov 27, 2024

   

   ndossche

   on Nov 27, 2024

   Member

   More actions

   This would work, just not very pretty...

   diff --git a/ext/standard/array.c b/ext/standard/array.c
   index ba1424f677f..3865ce0f25e 100644
   --- a/ext/standard/array.c
   +++ b/ext/standard/array.c
   @@ -3513,7 +3513,8 @@ PHP_FUNCTION(array_shift)
    			}
    			idx++;
    		}
   -		RETVAL_COPY_DEREF(val);
   +		ZVAL_COPY_VALUE(return_value, val);
   +		ZVAL_UNDEF(val);
    
    		/* Delete the first value */
    		zend_hash_packed_del_val(Z_ARRVAL_P(stack), val);
   @@ -3567,7 +3568,8 @@ PHP_FUNCTION(array_shift)
    			}
    			idx++;
    		}
   -		RETVAL_COPY_DEREF(val);
   +		ZVAL_COPY_VALUE(return_value, val);
   +		ZVAL_UNDEF(val);
    
    		/* Delete the first value */
    		zend_hash_del_bucket(Z_ARRVAL_P(stack), p);
   @@ -3591,6 +3593,10 @@ PHP_FUNCTION(array_shift)
    	}
    
    	zend_hash_internal_pointer_reset(Z_ARRVAL_P(stack));
   +
   +	if (Z_ISREF_P(return_value)) {
   +		zend_unwrap_reference(return_value);
   +	}
    }
    /* }}} */
    
   
4. ndossche

   changed the title [-]Assertion failure Zend/zend_hash.c:1520 array_shift()[/-] [+]Assertion failure in array_shift with self-referencing array[/+] on Nov 27, 2024
5. ndossche

   added a commit that references this issue on Nov 27, 2024

   Fix phpGH-16957: Assertion failure in array_shift with self-referenci…

   ...

   This issue will close once commit 8e3c0c1 is merged into the 'master' branch.

   8e3c0c1
6. ndossche

   linked a pull request that will close this issueFix GH-16957: Assertion failure in array_shift with self-referencing array #16970on Nov 27, 2024
7. ndossche

   added 2 commits that reference this issue on Nov 29, 2024

   Fix GH-16957: Assertion failure in array_shift with self-referencing …

   ...

   This issue will close once commit f1fc4e8 is merged into the 'master' branch.

   f1fc4e8

   Merge branch 'PHP-8.3' into PHP-8.4

   ...

   This issue will close once commit ab7c3b1 is merged into the 'master' branch.

   ab7c3b1
8. ndossche

   closed this as completedin f1fc4e8on Nov 29, 2024
9. ndossche

   added a commit that references this issue on Nov 29, 2024

   Merge branch 'PHP-8.4'

   ...

   This issue will close once commit 563da1b is merged into the 'master' branch.

   563da1b
10. ndossche

    added 2 commits that reference this issue on Jan 12, 2025

    Fix phpGH-17447: Assertion failure when array poping a self addressin…

    ...

    b109049

    Fix GH-17447: Assertion failure when array popping a self addressing …

    ...

    ae3ab37