Internal iterator functions can't handle UNDEF properties #16905

Activity

1. YuanchengJiang

   added

   Bug

   Status: Needs Triage

   on Nov 23, 2024
2. ndossche

   self-assigned this

   on Nov 23, 2024
3. ndossche commented on Nov 23, 2024

   

   ndossche

   on Nov 23, 2024

   Member

   More actions

   Similar issue to that simplexml bug most likely.
   Reduced to the following, which also works on 8.2:

   <?php
   $dom = new DOMDocument;
   $child = $dom->appendChild($dom->createElement('html'));
   var_dump(reset($child));
4. ndossche

   added

   Extension: dom

   Status: Verified

   Category: Engine

   and removed

   Status: Needs Triage

   on Nov 23, 2024
5. ndossche commented on Nov 23, 2024

   

   ndossche

   on Nov 23, 2024

   Member

   More actions

   Actually, it's more broad than only DOM.
   The reason it fails for DOM is because the get_properties handler is not implemented, returning an array of undef zvals.

   However, the following fails too:

   class X {
   	public int $a;
   }
   
   $x = new X;
   var_dump(reset($x));
   var_dump(current($x));
   var_dump(end($x));

   👍React with 👍1Reacted by Jiang Yuancheng
6. ndossche

   removed

   Extension: dom

   on Nov 23, 2024
7. ndossche

   changed the title [-]Segmentation fault at main/spprintf.c:376 when reset dom child in JIT[/-] [+]reset(), current(), end() can't handle UNDEF properties[/+] on Nov 23, 2024
8. ndossche

   changed the title [-]reset(), current(), end() can't handle UNDEF properties[/-] [+]Internal iterator functions can't handle UNDEF properties[/+] on Nov 23, 2024
9. ndossche

   added a commit that references this issue on Nov 23, 2024

   Fix phpGH-16905: Internal iterator functions can't handle UNDEF prope…

   ...

   This issue will close once commit ca79b10 is merged into the 'master' branch.

   ca79b10
10. ndossche

    linked a pull request that will close this issueFix GH-16905: Internal iterator functions can't handle UNDEF properties #16907on Nov 23, 2024
11. ndossche

    added

    Extension: standard

    and removed

    Category: Engine

    on Nov 23, 2024
12. ndossche

    added a commit that references this issue on Nov 28, 2024

    Fix GH-16905: Internal iterator functions can't handle UNDEF properties

    ...

    This issue will close once commit e1b4534 is merged into the 'master' branch.

    e1b4534
13. ndossche

    closed this as completedin e1b4534on Nov 28, 2024
14. ndossche

    added 3 commits that reference this issue on Nov 28, 2024

    Merge branch 'PHP-8.2' into PHP-8.3

    ...

    This issue will close once commit 6a195bd is merged into the 'master' branch.

    6a195bd

    Merge branch 'PHP-8.3' into PHP-8.4

    ...

    This issue will close once commit 3a80936 is merged into the 'master' branch.

    3a80936

    Merge branch 'PHP-8.4'

    ...

    This issue will close once commit c10f5ce is merged into the 'master' branch.

    c10f5ce