8.4 wrong fpmstatus output #16932

Activity

1. PLTytus

   added

   Bug

   Status: Needs Triage

   on Nov 25, 2024
2. devnexen

   added

   SAPI: fpm

   on Nov 25, 2024
3. devnexen commented on Nov 25, 2024

   

   devnexen

   on Nov 25, 2024

   Member

   More actions

   We might need a bit more to understand if the issue is relevant, i.e. configuration, how the logs look ...
4. PLTytus commented on Nov 25, 2024

   

   PLTytus

   on Nov 25, 2024

   Author

   More actions

   This is in /usr/local/etc/php-fpm.d/www.conf on php:8.4.1-fpm-alpine image

   [www]
   user = www-data
   group = www-data
   
   pm = dynamic
   pm.max_children = 200
   pm.start_servers = 10
   pm.min_spare_servers = 10
   pm.max_spare_servers = 20
   pm.max_requests = 200
   
   pm.status_listen = 127.0.0.1:9001
   pm.status_path = /fpmstatus
   

   No errors in logs.

   It kind of behaves like processes are overriding current stats: https://github.com/user-attachments/assets/61aab54b-2d25-45c7-b0d7-7562b8aaef2b

   There is no such issue on PHP 8.3
5. lucasnetau commented on Nov 26, 2024

   

   lucasnetau

   on Nov 26, 2024

   Last edited by lucasnetau

   Contributor

   More actions

   Possibly this PR #14153

   php-src/sapi/fpm/fpm/fpm_request.c

   Line 204 in ba6c005

   fpm_scoreboard_update_commit(0, 0, 0, 0, 0, 0, 0, proc->memory, FPM_SCOREBOARD_ACTION_SET, NULL);

   This is calling FPM_SCOREBOARD_ACTION_SET at the end of the request with all stats set to 0, the unmodified stats should be set as -1

   so either don't set the values

   --- fpm_scoreboard_update_commit(0, 0, 0, 0, 0, 0, 0, proc->memory, FPM_SCOREBOARD_ACTION_SET, NULL);
   +++ fpm_scoreboard_update_commit(-1, -1, -1, -1, -1, -1, -1, proc->memory, FPM_SCOREBOARD_ACTION_SET, NULL);

   or INC vs SET

   --- fpm_scoreboard_update_commit(0, 0, 0, 0, 0, 0, 0, proc->memory, FPM_SCOREBOARD_ACTION_SET, NULL);
   +++ fpm_scoreboard_update_commit(0, 0, 0, 0, 0, 0, 0, proc->memory, FPM_SCOREBOARD_ACTION_INC, NULL);
6. PLTytus commented on Nov 26, 2024

   

   PLTytus

   on Nov 26, 2024

   Author

   More actions

   Looking at fpm_scoreboard_update_commit definition, both @lucasnetau suggested solutions should resolve the issue.
   

   php-src/sapi/fpm/fpm/fpm_scoreboard.c

   Lines 100 to 177 in afa08b5

   	void fpm_scoreboard_update_commit(
   	int idle, int active, int lq, int lq_len, int requests, int max_children_reached,
   	int slow_rq, size_t memory_peak, int action, struct fpm_scoreboard_s *scoreboard) /* {{{ */
   	{
   	scoreboard = fpm_scoreboard_get_for_update(scoreboard);
   	if (!scoreboard) {
   	return;
   	}
   	if (action == FPM_SCOREBOARD_ACTION_SET) {
   	if (idle >= 0) {
   	scoreboard->idle = idle;
   	}
   	if (active >= 0) {
   	scoreboard->active = active;
   	}
   	if (lq >= 0) {
   	scoreboard->lq = lq;
   	}
   	if (lq_len >= 0) {
   	scoreboard->lq_len = lq_len;
   	}
   	#if HAVE_FPM_LQ /* prevent unnecessary test */
   	if (scoreboard->lq > scoreboard->lq_max) {
   	scoreboard->lq_max = scoreboard->lq;
   	}
   	#endif
   	if (requests >= 0) {
   	scoreboard->requests = requests;
   	}
   	if (max_children_reached >= 0) {
   	scoreboard->max_children_reached = max_children_reached;
   	}
   	if (slow_rq > 0) {
   	scoreboard->slow_rq = slow_rq;
   	}
   	} else {
   	if (scoreboard->idle + idle > 0) {
   	scoreboard->idle += idle;
   	} else {
   	scoreboard->idle = 0;
   	}
   	if (scoreboard->active + active > 0) {
   	scoreboard->active += active;
   	} else {
   	scoreboard->active = 0;
   	}
   	if (scoreboard->requests + requests > 0) {
   	scoreboard->requests += requests;
   	} else {
   	scoreboard->requests = 0;
   	}
   	if (scoreboard->max_children_reached + max_children_reached > 0) {
   	scoreboard->max_children_reached += max_children_reached;
   	} else {
   	scoreboard->max_children_reached = 0;
   	}
   	if (scoreboard->slow_rq + slow_rq > 0) {
   	scoreboard->slow_rq += slow_rq;
   	} else {
   	scoreboard->slow_rq = 0;
   	}
   	}
   	if (scoreboard->active > scoreboard->active_max) {
   	scoreboard->active_max = scoreboard->active;
   	}
   	if (scoreboard->memory_peak < memory_peak) {
   	scoreboard->memory_peak = memory_peak;
   	}
   	fpm_unlock(scoreboard->lock);
   	}
7. lucasnetau

   added a commit that references this issue on Nov 26, 2024

   Fix phpGH-16932 Scoreboard reset at end of request

   This issue will close once commit ec4683c is merged into the 'master' branch.

   ec4683c
8. cmb69

   linked a pull request that will close this issueFix GH-16932 Scoreboard reset at end of request #16941on Nov 26, 2024
9. bukka

   added a commit that references this issue on Nov 27, 2024

   Fix phpGH-16932: wrong FPM status output

   This issue will close once commit b68ef83 is merged into the 'master' branch.

   b68ef83
10. bukka

    removed

    Status: Needs Triage

    on Nov 27, 2024
11. bukka

    added 2 commits that reference this issue on Nov 28, 2024

    Fix GH-16932: wrong FPM status output

    ...

    This issue will close once commit d165670 is merged into the 'master' branch.

    d165670

    Update NEWS for GH-16932 fix

    This issue will close once commit e699753 is merged into the 'master' branch.

    e699753
12. bukka

    closed this as completedin d165670on Nov 28, 2024