Repository navigation
Changing trait provided final protected method to private results in warning #17214
Description
Description
The following code:
<?php
trait MyTrait
{
final protected function someMethod(): void {}
}
class Test
{
use MyTrait {
someMethod as private anotherMethod;
}
public function __construct()
{
$this->anotherMethod();
}
}Resulted in this output:
Warning: Private methods cannot be final as they are never overridden by other classes in /in/YtW3h on line 8
But I expected this output instead:
No error
PHP Version
8.3.14 and 8.4.1
Operating System
No response
Activity
iluuu1994 commentedon Dec 18, 2024
Not sure I would classify this as a bug, but it makes sense to relax this warning. To clarify, the
finalmodifier is still inherited. /cc @nielsdos, since you implemented GH-13179. Would you agree?ndossche commentedon Dec 18, 2024
Yeah I think I agree
ndossche commentedon Dec 19, 2024
When looking at the code that generates the warning, I don't see how the warning can be relaxed. Relaxing would be equivalent to dropping it I think.
Relax final+private warning for trait methods with inherited final
Relax final+private warning for trait methods with inherited final