PHP with tidy and custom-tags #20374

Activity

1. franck-paul

   added

   Bug

   Status: Needs Triage

   on Nov 3, 2025
2. devnexen

   added

   Extension: tidy

   on Nov 3, 2025
3. ndossche

   added

   Status: Verified

   and removed

   Status: Needs Triage

   on Nov 3, 2025
4. ndossche commented on Nov 3, 2025

   

   ndossche

   on Nov 3, 2025

   Member

   More actions

   I'll take a look. Enum translation appears to be broken.
   As a workaround for now you can use 'custom-tags' => 1,
5. ndossche commented on Nov 3, 2025

   

   ndossche

   on Nov 3, 2025

   Last edited by ndossche

   Member

   More actions

   On first sight the following would work, but have to double check (and probably add support for the IS_LONG case):

   diff --git a/ext/tidy/tidy.c b/ext/tidy/tidy.c
   index da0eb877d58..d8e762e1287 100644
   --- a/ext/tidy/tidy.c
   +++ b/ext/tidy/tidy.c
   @@ -254,10 +254,12 @@ static int _php_tidy_set_tidy_opt(TidyDoc doc, const char *optname, zval *value)
    			break;
    
    		case TidyInteger:
   -			lval = zval_get_long(value);
   -			if (tidyOptSetInt(doc, tidyOptGetId(opt), lval)) {
   +			str = zval_get_tmp_string(value, &tmp_str);
   +			if (tidyOptParseValue(doc, optname, ZSTR_VAL(str))) {
   +				zend_tmp_string_release(tmp_str);
    				return SUCCESS;
    			}
   +			zend_tmp_string_release(tmp_str);
    			break;
    
    		case TidyBoolean:
   
6. ndossche

   self-assigned this

   on Nov 3, 2025
7. ndossche

   linked a pull request that will close this issueFix GH-20374: PHP with tidy and custom-tags #20379on Nov 3, 2025
8. franck-paul

   added a commit that references this issue on Nov 4, 2025

   Adjust HtmlFilter for custom tags, but tidy is buggy about that (php/…

   ...

   a2e3ff0
9. ndossche

   added 3 commits that reference this issue on Nov 4, 2025

   Fix GH-20374: PHP with tidy and custom-tags

   ...

   This issue will close once commit fcc159b is merged into the 'master' branch.

   fcc159b

   Merge branch 'PHP-8.3' into PHP-8.4

   ...

   This issue will close once commit 07aab0c is merged into the 'master' branch.

   07aab0c

   Merge branch 'PHP-8.4' into PHP-8.5

   ...

   This issue will close once commit b8e9f7c is merged into the 'master' branch.

   b8e9f7c
10. ndossche

    closed this as completedin fcc159bon Nov 4, 2025
11. ndossche

    added a commit that references this issue on Nov 4, 2025

    Merge branch 'PHP-8.5'

    ...

    This issue will close once commit 5b5fe43 is merged into the 'master' branch.

    5b5fe43
12. franck-paul commented on Nov 4, 2025

    

    franck-paul

    on Nov 4, 2025

    Author

    More actions

    I'll take a look. Enum translation appears to be broken. As a workaround for now you can use 'custom-tags' => 1,

    I tried this value but the custom tag is still missing from output.
13. ndossche commented on Nov 4, 2025

    

    ndossche

    on Nov 4, 2025

    Member

    More actions

    The following code:

    <?php
    $str = '<custom-html-element>test</custom-html-element>';
    
    $config = [
    	'custom-tags' => 1,//'blocklevel',
    ];
    
    $tidy = new \tidy();
    $tidy->parseString($str, $config, 'utf8');
    $tidy->cleanRepair();
    
    $str = (string) $tidy->value;
    
    var_dump($str);	// should be <custom-html-element>test</custom-html-element>

    Outputs:

    string(124) "<!DOCTYPE html>
    <html>
    <head>
    <title></title>
    </head>
    <body>
    <custom-html-element>test</custom-html-element>
    </body>
    </html>"
    

    for me.
    Does this not work for you? What libtidy version do you have installed?