Repository navigation
Conversation
The out of range row warnings appended Z_LVAL_P() of a PgSql\Result object zval as a "result index", which is an address; pg_lo_write() pointed at a $buf parameter it does not have; and pg_lo_read() was the only place in the file wording the bound as "greater or equal than".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_fetch_result(),pg_fetch_row()/assoc()/array()/object(),pg_field_prtlen()andpg_field_is_null()printedZ_LVAL_P()of aPgSql\Resultobject as a "result index". the object address. The operand is dropped.pg_lo_write()referred to a nonexistent$bufparameter; it is$data.pg_lo_read()is the only check worded "greater or equal than"; use "greater than or equal to" like the rest of the file.Before:
After: