Skip to content

Add new config option for hiding some warnings from diagnosis system#2657

Merged
DL6ER merged 2 commits into
developmentfrom
misc_dnsmasq_warn
Oct 27, 2025
Merged

Add new config option for hiding some warnings from diagnosis system#2657
DL6ER merged 2 commits into
developmentfrom
misc_dnsmasq_warn

Conversation

@DL6ER

@DL6ER DL6ER commented Oct 23, 2025

Copy link
Copy Markdown
Member

What does this implement/fix?

Add config option misc.hide_dnsmasq_warn to suppress Pi-hole diagnosis warnings

This PR introduces a new configuration option, misc.hide_dnsmasq_warn (default false), which allows suppressing warnings in the Pi-hole diagnosis system related to non-critical dnsmasq messages. When enabled, these specific warnings will be hidden from the diagnosis output and message count.

The previously existing ability to filter based on an (undocumented) GET request parameter is removed for clarity.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories development branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

… the Pi-hole diagnosis system

Signed-off-by: Dominik <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team as a code owner October 23, 2025 17:07
@pralor-bot

Copy link
Copy Markdown

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/implementing-different-log-levels/82955/2

Comment thread src/config/config.c Outdated
Comment thread test/pihole.toml Outdated
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: Dominik <DL6ER@users.noreply.github.com>
@DL6ER DL6ER requested a review from rdwebdesign October 26, 2025 08:41
@DL6ER DL6ER changed the title Add new config option for hiding some warnings from disagnosis system Add new config option for hiding some warnings from diagnosis system Oct 27, 2025
@DL6ER DL6ER merged commit 23436f0 into development Oct 27, 2025
18 checks passed
@DL6ER DL6ER deleted the misc_dnsmasq_warn branch October 27, 2025 18:30
truecharts-admin added a commit to trueforge-org/truecharts that referenced this pull request Oct 27, 2025
#41169)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/pi-hole/pihole](https://redirect.github.com/pi-hole/docker-pi-hole)
| patch | `4fe41ce` -> `db6cdcd` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

Add the preset `:preserveSemverRanges` to your config if you don't want
to pin your dependencies.

---

### Release Notes

<details>
<summary>pi-hole/docker-pi-hole (ghcr.io/pi-hole/pihole)</summary>

###
[`v2025.10.2`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.10.2)

[Compare
Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.1...2025.10.2)

Nothing Docker-specific

Tagging to include FTL v6.3.1

<!-- Release notes generated using configuration in .github/release.yml
at master -->

#### What's Changed

- Fix pihole.format\_path(string) modifying string in-place by
[@&#8203;DL6ER](https://redirect.github.com/DL6ER) in
[pi-hole/FTL#2661](https://redirect.github.com/pi-hole/FTL/pull/2661)
- Do not try to renew certificate that is not used by
[@&#8203;DL6ER](https://redirect.github.com/DL6ER) in
[pi-hole/FTL#2666](https://redirect.github.com/pi-hole/FTL/pull/2666)
- Replace dots with underscores when creating env var examples by
[@&#8203;rdwebdesign](https://redirect.github.com/rdwebdesign) in
[pi-hole/FTL#2669](https://redirect.github.com/pi-hole/FTL/pull/2669)
- Grammar corrections in documentation by
[@&#8203;alexxroche](https://redirect.github.com/alexxroche) in
[pi-hole/FTL#2670](https://redirect.github.com/pi-hole/FTL/pull/2670)
- Add new config option for hiding some warnings from diagnosis system
by [@&#8203;DL6ER](https://redirect.github.com/DL6ER) in
[pi-hole/FTL#2657](https://redirect.github.com/pi-hole/FTL/pull/2657)

#### New Contributors

- [@&#8203;alexxroche](https://redirect.github.com/alexxroche) made
their first contribution in
[pi-hole/FTL#2670](https://redirect.github.com/pi-hole/FTL/pull/2670)

**Full Changelog**:
<pi-hole/FTL@v6.3...v6.3.1>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44Mi4xMCIsInVwZGF0ZWRJblZlciI6IjQxLjgyLjEwIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvcGF0Y2giXX0=-->
github-actions Bot pushed a commit to bigbeartechworld/big-bear-universal-apps that referenced this pull request Oct 30, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [jacklul/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | patch | `2025.10.1` -> `2025.10.3` |

---

### Release Notes

<details>
<summary>pi-hole/docker-pi-hole (jacklul/pihole)</summary>

### [`v2025.10.3`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.10.3)

[Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.2...2025.10.3)

Pi-hole releases are a lot like London Buses. You don't see one for ages, and then they all come along at once

<!-- Release notes generated using configuration in .github/release.yml at master -->

#### What's Changed (Docker Specific)

- Remove remaining hard-coded FTL log paths by [@&#8203;casperklein](https://redirect.github.com/casperklein) in [#&#8203;1929](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1929)

**Full Changelog**: <pi-hole/docker-pi-hole@2025.10.2...2025.10.3>

<!-- Release notes generated using configuration in .github/release.yml at master -->

#### What's Changed (FTL v6.3.2)

- Fix pihole.format\_path() memory handling by [@&#8203;DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2675](https://redirect.github.com/pi-hole/FTL/pull/2675)

**Full Changelog**: <pi-hole/FTL@v6.3.1...v6.3.2>

<!-- Release notes generated using configuration in .github/release.yml at development -->

#### What's Changed (Core v6.2.2)

- Create version file, if not existing (on first Container start) by [@&#8203;casperklein](https://redirect.github.com/casperklein) in [pi-hole/pi-hole#6440](https://redirect.github.com/pi-hole/pi-hole/pull/6440)
- Add log file path variables and ensure log files are created if missing by [@&#8203;Yannick7777](https://redirect.github.com/Yannick7777) in [pi-hole/pi-hole#6441](https://redirect.github.com/pi-hole/pi-hole/pull/6441)
- Add bind9-dnsutils as dependency for APT based systems by [@&#8203;yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/pi-hole#6444](https://redirect.github.com/pi-hole/pi-hole/pull/6444)

#### New Contributors

- [@&#8203;Yannick7777](https://redirect.github.com/Yannick7777) made their first contribution in [pi-hole/pi-hole#6441](https://redirect.github.com/pi-hole/pi-hole/pull/6441)

**Full Changelog**: <pi-hole/pi-hole@v6.2.1...v6.2.2>

### [`v2025.10.2`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.10.2)

[Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.1...2025.10.2)

Nothing Docker-specific

Tagging to include FTL v6.3.1

<!-- Release notes generated using configuration in .github/release.yml at master -->

#### What's Changed

- Fix pihole.format\_path(string) modifying string in-place by [@&#8203;DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2661](https://redirect.github.com/pi-hole/FTL/pull/2661)
- Do not try to renew certificate that is not used by [@&#8203;DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2666](https://redirect.github.com/pi-hole/FTL/pull/2666)
- Replace dots with underscores when creating env var examples by [@&#8203;rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/FTL#2669](https://redirect.github.com/pi-hole/FTL/pull/2669)
- Grammar corrections in documentation by [@&#8203;alexxroche](https://redirect.github.com/alexxroche) in [pi-hole/FTL#2670](https://redirect.github.com/pi-hole/FTL/pull/2670)
- Add new config option for hiding some warnings from diagnosis system by [@&#8203;DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2657](https://redirect.github.com/pi-hole/FTL/pull/2657)

#### New Contributors

- [@&#8203;alexxroche](https://redirect.github.com/alexxroche) made their first contribution in [pi-hole/FTL#2670](https://redirect.github.com/pi-hole/FTL/pull/2670)

**Full Changelog**: <pi-hole/FTL@v6.3...v6.3.1>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNTkuNCIsInVwZGF0ZWRJblZlciI6IjQxLjE1OS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants