Fix pihole.format_path(string) modifying string in-place#2661
Merged
Conversation
…g memory of the process. This has consequences for all similar strings, even if saved in other variables as Lua internalized string so all equal strings, like "a/b" and whatever has a result similar to "a/b" are actually one and the same string to save memory Signed-off-by: Dominik <dl6er@dl6er.de>
yubiuser
approved these changes
Oct 26, 2025
yubiuser
left a comment
Member
There was a problem hiding this comment.
Does this fix a reported issue?
Member
|
Yes: it fixes pi-hole/web#3641 |
rdwebdesign
approved these changes
Oct 26, 2025
truecharts-admin
added a commit
to trueforge-org/truecharts
that referenced
this pull request
Oct 27, 2025
#41169) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/pi-hole/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | patch | `4fe41ce` -> `db6cdcd` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. Add the preset `:preserveSemverRanges` to your config if you don't want to pin your dependencies. --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (ghcr.io/pi-hole/pihole)</summary> ### [`v2025.10.2`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.10.2) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.1...2025.10.2) Nothing Docker-specific Tagging to include FTL v6.3.1 <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed - Fix pihole.format\_path(string) modifying string in-place by [@​DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2661](https://redirect.github.com/pi-hole/FTL/pull/2661) - Do not try to renew certificate that is not used by [@​DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2666](https://redirect.github.com/pi-hole/FTL/pull/2666) - Replace dots with underscores when creating env var examples by [@​rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/FTL#2669](https://redirect.github.com/pi-hole/FTL/pull/2669) - Grammar corrections in documentation by [@​alexxroche](https://redirect.github.com/alexxroche) in [pi-hole/FTL#2670](https://redirect.github.com/pi-hole/FTL/pull/2670) - Add new config option for hiding some warnings from diagnosis system by [@​DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2657](https://redirect.github.com/pi-hole/FTL/pull/2657) #### New Contributors - [@​alexxroche](https://redirect.github.com/alexxroche) made their first contribution in [pi-hole/FTL#2670](https://redirect.github.com/pi-hole/FTL/pull/2670) **Full Changelog**: <pi-hole/FTL@v6.3...v6.3.1> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44Mi4xMCIsInVwZGF0ZWRJblZlciI6IjQxLjgyLjEwIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInJlbm92YXRlL2NvbnRhaW5lciIsInR5cGUvcGF0Y2giXX0=-->
github-actions Bot
pushed a commit
to bigbeartechworld/big-bear-universal-apps
that referenced
this pull request
Oct 30, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [jacklul/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | patch | `2025.10.1` -> `2025.10.3` | --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (jacklul/pihole)</summary> ### [`v2025.10.3`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.10.3) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.2...2025.10.3) Pi-hole releases are a lot like London Buses. You don't see one for ages, and then they all come along at once <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed (Docker Specific) - Remove remaining hard-coded FTL log paths by [@​casperklein](https://redirect.github.com/casperklein) in [#​1929](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1929) **Full Changelog**: <pi-hole/docker-pi-hole@2025.10.2...2025.10.3> <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed (FTL v6.3.2) - Fix pihole.format\_path() memory handling by [@​DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2675](https://redirect.github.com/pi-hole/FTL/pull/2675) **Full Changelog**: <pi-hole/FTL@v6.3.1...v6.3.2> <!-- Release notes generated using configuration in .github/release.yml at development --> #### What's Changed (Core v6.2.2) - Create version file, if not existing (on first Container start) by [@​casperklein](https://redirect.github.com/casperklein) in [pi-hole/pi-hole#6440](https://redirect.github.com/pi-hole/pi-hole/pull/6440) - Add log file path variables and ensure log files are created if missing by [@​Yannick7777](https://redirect.github.com/Yannick7777) in [pi-hole/pi-hole#6441](https://redirect.github.com/pi-hole/pi-hole/pull/6441) - Add bind9-dnsutils as dependency for APT based systems by [@​yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/pi-hole#6444](https://redirect.github.com/pi-hole/pi-hole/pull/6444) #### New Contributors - [@​Yannick7777](https://redirect.github.com/Yannick7777) made their first contribution in [pi-hole/pi-hole#6441](https://redirect.github.com/pi-hole/pi-hole/pull/6441) **Full Changelog**: <pi-hole/pi-hole@v6.2.1...v6.2.2> ### [`v2025.10.2`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.10.2) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.1...2025.10.2) Nothing Docker-specific Tagging to include FTL v6.3.1 <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed - Fix pihole.format\_path(string) modifying string in-place by [@​DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2661](https://redirect.github.com/pi-hole/FTL/pull/2661) - Do not try to renew certificate that is not used by [@​DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2666](https://redirect.github.com/pi-hole/FTL/pull/2666) - Replace dots with underscores when creating env var examples by [@​rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/FTL#2669](https://redirect.github.com/pi-hole/FTL/pull/2669) - Grammar corrections in documentation by [@​alexxroche](https://redirect.github.com/alexxroche) in [pi-hole/FTL#2670](https://redirect.github.com/pi-hole/FTL/pull/2670) - Add new config option for hiding some warnings from diagnosis system by [@​DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2657](https://redirect.github.com/pi-hole/FTL/pull/2657) #### New Contributors - [@​alexxroche](https://redirect.github.com/alexxroche) made their first contribution in [pi-hole/FTL#2670](https://redirect.github.com/pi-hole/FTL/pull/2670) **Full Changelog**: <pi-hole/FTL@v6.3...v6.3.1> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNTkuNCIsInVwZGF0ZWRJblZlciI6IjQxLjE1OS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The provided Lua function
pihole.format_path(string)should work on a copy to not overwrite the string memory of the process. This has consequences for all similar strings, even if saved in other variables as Lua internalized string so all equal strings, like "a/b" and whatever has a result similar to "a/b" are actually one and the same string to save memoryRelated issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentbranch.