Add validation for ntp.sync.server by DL6ER · Pull Request #2667 · pi-hole/FTL

DL6ER · 2025-10-26T18:00:07Z

What does this implement/fix?

Validation should ensure that ntp.sync.server can only be either a valid IP or a hostname.

Note: I'm opening this as draft because - right now - the resulting crash was not reproducible by me. It is impossible on this branch, however, I'd still like to also fix the underlying issue in case the user responds with the requested backtrace. The actual crash is fixed by #2684

This PR also adds printing which NTP service has been detected when FTL decides not to launch its own NTP server. This makes it easier to see what needs to be disabled in order to test NTP related functionality on a given machine.

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A

By submitting this pull request, I confirm the following:

I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code.
I am willing to help maintain this change if there are issues with it later.
It is compatible with the EUPL 1.2 license
I have squashed any insignificant commits. (git rebase)

Checklist:

The code change is tested and works locally.
I based my code and PRs against the repositories development branch.
I signed off all commits. Pi-hole enforces the DCO for all contributions
I signed all my commits. Pi-hole requires signatures to verify authorship
I have read the above and my PR is ready for review.

…lid IP or a hostname Signed-off-by: Dominik <dl6er@dl6er.de>

#41431) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/pi-hole/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | minor | `7f2dff3` -> `e28e239` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. Add the preset `:preserveSemverRanges` to your config if you don't want to pin your dependencies. --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (ghcr.io/pi-hole/pihole)</summary> ### [`v2025.11.0`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.0) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.3...2025.11.0) Re-release, the `riscv64` part of the image is not currently building and preventing the image from being published for other architectures. I have disabled the `riscv64` build for the time being until I have time to debug what is happening with it. I If you are running this image on `riscv64`, please get in touch via issues if you are willing to help troubleshoot the process! ## Otherwise, nothing specific for Docker, tagging to get an FTL change out: #### What's Changed (FTL v6.3.3) - Fix crash in NTP error handling code by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2684](https://redirect.github.com/pi-hole/FTL/pull/2684) - Add validation for ntp.sync.server by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2667](https://redirect.github.com/pi-hole/FTL/pull/2667) - Be more explicit about required path and query parameters for list manipulation by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/FTL#2689](https://redirect.github.com/pi-hole/FTL/pull/2689) - Pi-hole FTL v6.3.3 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2693](https://redirect.github.com/pi-hole/FTL/pull/2693) **Full Changelog**: <pi-hole/FTL@v6.3.2...v6.3.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [jacklul/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | minor | `2025.10.3` -> `2025.11.0` | --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (jacklul/pihole)</summary> ### [`v2025.11.0`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.0) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.3...2025.11.0) Re-release, the `riscv64` part of the image is not currently building and preventing the image from being published for other architectures. I have disabled the `riscv64` build for the time being until I have time to debug what is happening with it. I If you are running this image on `riscv64`, please get in touch via issues if you are willing to help troubleshoot the process! ## Otherwise, nothing specific for Docker, tagging to get an FTL change out: ##### What's Changed (FTL v6.3.3) - Fix crash in NTP error handling code by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2684](https://redirect.github.com/pi-hole/FTL/pull/2684) - Add validation for ntp.sync.server by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2667](https://redirect.github.com/pi-hole/FTL/pull/2667) - Be more explicit about required path and query parameters for list manipulation by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/FTL#2689](https://redirect.github.com/pi-hole/FTL/pull/2689) - Pi-hole FTL v6.3.3 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2693](https://redirect.github.com/pi-hole/FTL/pull/2693) **Full Changelog**: <pi-hole/FTL@v6.3.2...v6.3.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pihole/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | minor | `2025.10.3` -> `2025.11.0` | --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (pihole/pihole)</summary> ### [`v2025.11.0`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.0) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.3...2025.11.0) Re-release, the `riscv64` part of the image is not currently building and preventing the image from being published for other architectures. I have disabled the `riscv64` build for the time being until I have time to debug what is happening with it. I If you are running this image on `riscv64`, please get in touch via issues if you are willing to help troubleshoot the process! ## Otherwise, nothing specific for Docker, tagging to get an FTL change out: ##### What's Changed (FTL v6.3.3) - Fix crash in NTP error handling code by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2684](https://redirect.github.com/pi-hole/FTL/pull/2684) - Add validation for ntp.sync.server by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2667](https://redirect.github.com/pi-hole/FTL/pull/2667) - Be more explicit about required path and query parameters for list manipulation by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/FTL#2689](https://redirect.github.com/pi-hole/FTL/pull/2689) - Pi-hole FTL v6.3.3 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2693](https://redirect.github.com/pi-hole/FTL/pull/2693) **Full Changelog**: <pi-hole/FTL@v6.3.2...v6.3.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps).

…ag to v2025.11.0 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [bigbeartechworld/big-bear-pihole-unbound](https://redirect.github.com/pi-hole/docker-pi-hole) | minor | `2025.08.0` -> `2025.11.0` | --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (bigbeartechworld/big-bear-pihole-unbound)</summary> ### [`v2025.11.0`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.0) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.08.0...2025.11.0) Re-release, the `riscv64` part of the image is not currently building and preventing the image from being published for other architectures. I have disabled the `riscv64` build for the time being until I have time to debug what is happening with it. I If you are running this image on `riscv64`, please get in touch via issues if you are willing to help troubleshoot the process! ## Otherwise, nothing specific for Docker, tagging to get an FTL change out: #### What's Changed (FTL v6.3.3) - Fix crash in NTP error handling code by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2684](https://redirect.github.com/pi-hole/FTL/pull/2684) - Add validation for ntp.sync.server by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2667](https://redirect.github.com/pi-hole/FTL/pull/2667) - Be more explicit about required path and query parameters for list manipulation by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/FTL#2689](https://redirect.github.com/pi-hole/FTL/pull/2689) - Pi-hole FTL v6.3.3 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2693](https://redirect.github.com/pi-hole/FTL/pull/2693) **Full Changelog**: <pi-hole/FTL@v6.3.2...v6.3.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps).

Validation should ensure that ntp.sync.server can only be either a va…

5929bfd

…lid IP or a hostname Signed-off-by: Dominik <dl6er@dl6er.de>

DL6ER added the Bugfix label Oct 26, 2025

DL6ER linked an issue Oct 26, 2025 that may be closed by this pull request

Multiple IP Addresses defined in ntp.sync.server causes crash loop #2660

Closed

DL6ER mentioned this pull request Oct 27, 2025

FTL 6.3.1 #2673

Merged

1 task

breadtk mentioned this pull request Oct 30, 2025

Multiple IP Addresses defined in ntp.sync.server causes crash loop #2660

Closed

DL6ER marked this pull request as ready for review October 30, 2025 18:22

DL6ER requested a review from a team as a code owner October 30, 2025 18:22

DL6ER linked an issue Oct 30, 2025 that may be closed by this pull request

FTL v6.3.2: Crash #2682

Closed

yubiuser approved these changes Oct 30, 2025

View reviewed changes

rdwebdesign approved these changes Oct 30, 2025

View reviewed changes

DL6ER merged commit dab2107 into development Oct 31, 2025
18 checks passed

DL6ER deleted the fix/ntp_sync_server_ip_domain branch October 31, 2025 19:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add validation for ntp.sync.server#2667

Add validation for ntp.sync.server#2667
DL6ER merged 1 commit into
developmentfrom
fix/ntp_sync_server_ip_domain

DL6ER commented Oct 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

DL6ER commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this implement/fix?

Checklist:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DL6ER commented Oct 26, 2025 •

edited

Loading