Pi-hole FTL v6.3.3 by DL6ER · Pull Request #2693 · pi-hole/FTL

DL6ER · 2025-11-04T19:06:29Z

What does this implement/fix?

This is a bug fix release concerning undefined behavior in rarely (but more than never) used NTP error handling code.

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A

By submitting this pull request, I confirm the following:

I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code.
I am willing to help maintain this change if there are issues with it later.
It is compatible with the EUPL 1.2 license
I have squashed any insignificant commits. (git rebase)

Checklist:

The code change is tested and works locally.
I based my code and PRs against the repositories development branch.
I signed off all commits. Pi-hole enforces the DCO for all contributions
I signed all my commits. Pi-hole requires signatures to verify authorship
I have read the above and my PR is ready for review.

…lid IP or a hostname Signed-off-by: Dominik <dl6er@dl6er.de>

Sync master back into development

Signed-off-by: Dominik <dl6er@dl6er.de>

Fix crash in NTP error handling code

Add validation for ntp.sync.server

Bumps the github_action-dependencies group with 1 update in the / directory: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 4.31.0 to 4.31.2 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4e94bd1...0499de3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.31.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_action-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>

…opment-github_action-dependencies-02cf758a13 Bump github/codeql-action from 4.31.0 to 4.31.2 in the github_action-dependencies group across 1 directory

…nipulation Signed-off-by: yubiuser <github@yubiuser.dev>

Be more explicit about required path and query parameters for list manipulation

#41431) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/pi-hole/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | minor | `7f2dff3` -> `e28e239` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. Add the preset `:preserveSemverRanges` to your config if you don't want to pin your dependencies. --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (ghcr.io/pi-hole/pihole)</summary> ### [`v2025.11.0`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.0) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.3...2025.11.0) Re-release, the `riscv64` part of the image is not currently building and preventing the image from being published for other architectures. I have disabled the `riscv64` build for the time being until I have time to debug what is happening with it. I If you are running this image on `riscv64`, please get in touch via issues if you are willing to help troubleshoot the process! ## Otherwise, nothing specific for Docker, tagging to get an FTL change out: #### What's Changed (FTL v6.3.3) - Fix crash in NTP error handling code by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2684](https://redirect.github.com/pi-hole/FTL/pull/2684) - Add validation for ntp.sync.server by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2667](https://redirect.github.com/pi-hole/FTL/pull/2667) - Be more explicit about required path and query parameters for list manipulation by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/FTL#2689](https://redirect.github.com/pi-hole/FTL/pull/2689) - Pi-hole FTL v6.3.3 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2693](https://redirect.github.com/pi-hole/FTL/pull/2693) **Full Changelog**: <pi-hole/FTL@v6.3.2...v6.3.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [jacklul/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | minor | `2025.10.3` -> `2025.11.0` | --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (jacklul/pihole)</summary> ### [`v2025.11.0`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.0) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.3...2025.11.0) Re-release, the `riscv64` part of the image is not currently building and preventing the image from being published for other architectures. I have disabled the `riscv64` build for the time being until I have time to debug what is happening with it. I If you are running this image on `riscv64`, please get in touch via issues if you are willing to help troubleshoot the process! ## Otherwise, nothing specific for Docker, tagging to get an FTL change out: ##### What's Changed (FTL v6.3.3) - Fix crash in NTP error handling code by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2684](https://redirect.github.com/pi-hole/FTL/pull/2684) - Add validation for ntp.sync.server by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2667](https://redirect.github.com/pi-hole/FTL/pull/2667) - Be more explicit about required path and query parameters for list manipulation by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/FTL#2689](https://redirect.github.com/pi-hole/FTL/pull/2689) - Pi-hole FTL v6.3.3 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2693](https://redirect.github.com/pi-hole/FTL/pull/2693) **Full Changelog**: <pi-hole/FTL@v6.3.2...v6.3.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pihole/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | minor | `2025.10.3` -> `2025.11.0` | --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (pihole/pihole)</summary> ### [`v2025.11.0`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.0) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.10.3...2025.11.0) Re-release, the `riscv64` part of the image is not currently building and preventing the image from being published for other architectures. I have disabled the `riscv64` build for the time being until I have time to debug what is happening with it. I If you are running this image on `riscv64`, please get in touch via issues if you are willing to help troubleshoot the process! ## Otherwise, nothing specific for Docker, tagging to get an FTL change out: ##### What's Changed (FTL v6.3.3) - Fix crash in NTP error handling code by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2684](https://redirect.github.com/pi-hole/FTL/pull/2684) - Add validation for ntp.sync.server by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2667](https://redirect.github.com/pi-hole/FTL/pull/2667) - Be more explicit about required path and query parameters for list manipulation by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/FTL#2689](https://redirect.github.com/pi-hole/FTL/pull/2689) - Pi-hole FTL v6.3.3 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2693](https://redirect.github.com/pi-hole/FTL/pull/2693) **Full Changelog**: <pi-hole/FTL@v6.3.2...v6.3.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps).

…ag to v2025.11.0 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [bigbeartechworld/big-bear-pihole-unbound](https://redirect.github.com/pi-hole/docker-pi-hole) | minor | `2025.08.0` -> `2025.11.0` | --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (bigbeartechworld/big-bear-pihole-unbound)</summary> ### [`v2025.11.0`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.0) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.08.0...2025.11.0) Re-release, the `riscv64` part of the image is not currently building and preventing the image from being published for other architectures. I have disabled the `riscv64` build for the time being until I have time to debug what is happening with it. I If you are running this image on `riscv64`, please get in touch via issues if you are willing to help troubleshoot the process! ## Otherwise, nothing specific for Docker, tagging to get an FTL change out: #### What's Changed (FTL v6.3.3) - Fix crash in NTP error handling code by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2684](https://redirect.github.com/pi-hole/FTL/pull/2684) - Add validation for ntp.sync.server by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2667](https://redirect.github.com/pi-hole/FTL/pull/2667) - Be more explicit about required path and query parameters for list manipulation by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/FTL#2689](https://redirect.github.com/pi-hole/FTL/pull/2689) - Pi-hole FTL v6.3.3 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2693](https://redirect.github.com/pi-hole/FTL/pull/2693) **Full Changelog**: <pi-hole/FTL@v6.3.2...v6.3.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps).

DL6ER and others added 9 commits October 26, 2025 08:01

Validation should ensure that ntp.sync.server can only be either a va…

5929bfd

…lid IP or a hostname Signed-off-by: Dominik <dl6er@dl6er.de>

Merge pull request #2676 from pi-hole/master

f31b28a

Sync master back into development

Fix crash in NTP error handling code

28f2519

Signed-off-by: Dominik <dl6er@dl6er.de>

Merge pull request #2684 from pi-hole/fix/ntp_error_crash

bfa8f89

Fix crash in NTP error handling code

Merge pull request #2667 from pi-hole/fix/ntp_sync_server_ip_domain

dab2107

Add validation for ntp.sync.server

Merge pull request #2686 from pi-hole/dependabot-github_actions-devel…

1f78a70

…opment-github_action-dependencies-02cf758a13 Bump github/codeql-action from 4.31.0 to 4.31.2 in the github_action-dependencies group across 1 directory

Be more explicit about required path and query parameters for list ma…

9c3aed7

…nipulation Signed-off-by: yubiuser <github@yubiuser.dev>

Merge pull request #2689 from pi-hole/list_doc

75c53eb

Be more explicit about required path and query parameters for list manipulation

DL6ER requested a review from a team as a code owner November 4, 2025 19:06

DL6ER added Bugfix Release labels Nov 4, 2025

yubiuser approved these changes Nov 4, 2025

View reviewed changes

rdwebdesign approved these changes Nov 4, 2025

View reviewed changes

DL6ER merged commit a0186fd into master Nov 4, 2025
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Pi-hole FTL v6.3.3#2693

Pi-hole FTL v6.3.3#2693
DL6ER merged 9 commits into
masterfrom
development

DL6ER commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

DL6ER commented Nov 4, 2025

What does this implement/fix?

Checklist:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants