Fix authentication redirect when webhome is / (fixes #2518) by averyvigolo · Pull Request #2610 · pi-hole/FTL

averyvigolo · 2025-08-24T17:39:09Z

What does this PR aim to accomplish?:

This fixes an infinite reload on the home page when authentication is enabled. The reloads are caused by XHR calls to the API, which receive a 401 response, and the error handlers simply reload the page.

This was raised in NixOS/nixpkgs#435150

How does this PR accomplish the above?:

If webhome is not set, we don't need to redirect requests to / at all. Let the default request handler run, to properly handle authentication. So, conditionally enable redirect_root_handler, if webhome is not empty or /. This fixes the problem, as there's an immediate redirect to /login, before any XHR calls.

Remove the initial fix in #2521, as it is no longer necessary. That fix involved checking in redirect_root_handler, if the redirect destination is the same as the request URI.

This fixes #2518.

By submitting this pull request, I confirm the following:

I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code and I have tested my changes.
I am willing to help maintain this change if there are issues with it later.
It is compatible with the EUPL 1.2 license
I have squashed any insignificant commits. (git rebase)
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

I have read the above and my PR is ready for review. Check this box to confirm

DL6ER · 2025-10-30T18:29:36Z

Sorry for this having fallen between the cracks, could you bring your commit onto the latest development so we can merge it? Sorry again for the extra trouble...

This fixes an infinite redirect on the home page when authentication is enabled. The redirects are caused by XHR calls to the API, which receive a 401 response, and the error handlers simply reload the page. If webhome is not set, the default request handler should be used to properly handle authentication. So, conditionally enable redirect_root_handler, if webhome is not empty or `/`. This fixes the problem, as there's an immediate redirect to /login, before any XHR calls. Remove the initial fix in pi-hole#2521, as it is no longer necessary. That fix involved checking in redirect_root_handler, if the redirect destination is the same as the request URI. Signed-off-by: averyvigolo <avery@averyv.me>

averyvigolo · 2025-10-30T19:14:37Z

Sorry for this having fallen between the cracks, could you bring your commit onto the latest development so we can merge it? Sorry again for the extra trouble...

Should be up to date now, thanks!
Not sure why it didn't let me do it through the web UI.

pralor-bot · 2025-11-27T20:00:39Z

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v6-4-web-v6-4-and-core-v6-3-released/83680/1

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pihole/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | patch | `2025.11.0` -> `2025.11.1` | --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (pihole/pihole)</summary> ### [`v2025.11.1`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.1) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.11.0...2025.11.1)  #### What's Changed (Docker Specific) - Fix build status badge in readme by [@nol166](https://redirect.github.com/nol166) in [#1938](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1938) - Add RISCV back by [@yubiuser](https://redirect.github.com/yubiuser) in [#1939](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1939) - Improve FTL startup detection and log tailing by [@PromoFaux](https://redirect.github.com/PromoFaux) in [#1940](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1940) - Set DNS listening mode to 'ALL' in docker-compose.yml example by [@cornshakes](https://redirect.github.com/cornshakes) in [#1946](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1946) - Add instructions for excluding Pi-hole from Watchtower updates by [@chippy01](https://redirect.github.com/chippy01) in [#1949](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1949) #### New Contributors - [@nol166](https://redirect.github.com/nol166) made their first contribution in [#1938](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1938) - [@cornshakes](https://redirect.github.com/cornshakes) made their first contribution in [#1946](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1946) - [@chippy01](https://redirect.github.com/chippy01) made their first contribution in [#1949](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1949) **Full Changelog**: <pi-hole/docker-pi-hole@2025.11.0...2025.11.1> ***  #### What's Changed (FTL v6.4.1) - Fix API specs and example for dns.upstreams in config.yaml by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/FTL#2696](https://redirect.github.com/pi-hole/FTL/pull/2696) - gravity update - silently discard unicode BOM if present by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/FTL#2702](https://redirect.github.com/pi-hole/FTL/pull/2702) - Update embedded SQLite to 3.51.0 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2704](https://redirect.github.com/pi-hole/FTL/pull/2704) - Get earliest query timestamp from database by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/FTL#2706](https://redirect.github.com/pi-hole/FTL/pull/2706) - Increase buffer length for query string by [@mwoolweaver](https://redirect.github.com/mwoolweaver) in [pi-hole/FTL#2709](https://redirect.github.com/pi-hole/FTL/pull/2709) - Reduce DNS resolver locking during database interaction by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2700](https://redirect.github.com/pi-hole/FTL/pull/2700) - Make colour output optional in streaming gravity API call by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/FTL#2718](https://redirect.github.com/pi-hole/FTL/pull/2718) - api/dhcp/leases Allow for hwaddr > 48 bits by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/FTL#2724](https://redirect.github.com/pi-hole/FTL/pull/2724) - Add rate-limiting for TOTP validation by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2719](https://redirect.github.com/pi-hole/FTL/pull/2719) - Implement simple partial matching for regex in /api/search/{domain} by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2705](https://redirect.github.com/pi-hole/FTL/pull/2705) - Performance optimizations: string processing, memory management, and compiler flags by [@Copilot](https://redirect.github.com/Copilot) in [pi-hole/FTL#2571](https://redirect.github.com/pi-hole/FTL/pull/2571) - Fix authentication redirect when webhome is / (fixes [#2518](https://redirect.github.com/pi-hole/docker-pi-hole/issues/2518)) by [@averyvigolo](https://redirect.github.com/averyvigolo) in [pi-hole/FTL#2610](https://redirect.github.com/pi-hole/FTL/pull/2610) - Reduce database locking and add timing debug setting by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2688](https://redirect.github.com/pi-hole/FTL/pull/2688) #### New Contributors - [@mwoolweaver](https://redirect.github.com/mwoolweaver) made their first contribution in [pi-hole/FTL#2709](https://redirect.github.com/pi-hole/FTL/pull/2709) - [@Copilot](https://redirect.github.com/Copilot) made their first contribution in [pi-hole/FTL#2571](https://redirect.github.com/pi-hole/FTL/pull/2571) - [@averyvigolo](https://redirect.github.com/averyvigolo) made their first contribution in [pi-hole/FTL#2610](https://redirect.github.com/pi-hole/FTL/pull/2610) **Full Changelog**: <pi-hole/FTL@v6.3.3...v6.4>   #### What's Changed (Web v6.4) - Start using commented tags for editorconfig-checker by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/web#3643](https://redirect.github.com/pi-hole/web/pull/3643) - Remove some unused code (leftover from v5) by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/web#3636](https://redirect.github.com/pi-hole/web/pull/3636) - Make sure the table is redrawn after the dnssec API call returns by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/web#3645](https://redirect.github.com/pi-hole/web/pull/3645) - Add hint that partial matching may not return all possible results by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/web#3654](https://redirect.github.com/pi-hole/web/pull/3654) - Enable one-time code autofill for TOTP input by [@sebastianlivoni](https://redirect.github.com/sebastianlivoni) in [pi-hole/web#3658](https://redirect.github.com/pi-hole/web/pull/3658) - Set "All Time " range for query log datepicker based on Database ranges (moment) by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/web#3657](https://redirect.github.com/pi-hole/web/pull/3657) - Request ANSI colour codes when calling gravity API by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/web#3662](https://redirect.github.com/pi-hole/web/pull/3662) - Pi-hole Web v6.4 by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/web#3670](https://redirect.github.com/pi-hole/web/pull/3670) #### New Contributors - [@sebastianlivoni](https://redirect.github.com/sebastianlivoni) made their first contribution in [pi-hole/web#3658](https://redirect.github.com/pi-hole/web/pull/3658) **Full Changelog**: <pi-hole/web@v6.3...v6.4> #### What's Changed (Core v6.3) - Add Fedora 43 to test suite by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/pi-hole#6453](https://redirect.github.com/pi-hole/pi-hole/pull/6453) - Fix libcap capabilities not being granted on OpenRC distros by [@Sparronator9999](https://redirect.github.com/Sparronator9999) in [pi-hole/pi-hole#6456](https://redirect.github.com/pi-hole/pi-hole/pull/6456) - systemd service - don't use deprecated PermissionsStartOnly by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/pi-hole#6465](https://redirect.github.com/pi-hole/pi-hole/pull/6465) - debug - speed up processing and display of file contents and services by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/pi-hole#6469](https://redirect.github.com/pi-hole/pi-hole/pull/6469) - Use port from dns.port in piholeDebug.sh by [@darkexplosiveqwx](https://redirect.github.com/darkexplosiveqwx) in [pi-hole/pi-hole#6475](https://redirect.github.com/pi-hole/pi-hole/pull/6475) - Improve gravity tables presentation on the debug log by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/pi-hole#6460](https://redirect.github.com/pi-hole/pi-hole/pull/6460) #### New Contributors - [@Sparronator9999](https://redirect.github.com/Sparronator9999) made their first contribution in [pi-hole/pi-hole#6456](https://redirect.github.com/pi-hole/pi-hole/pull/6456) **Full Changelog**: <pi-hole/pi-hole@v6.2.2...v6.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps).

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [jacklul/pihole](https://redirect.github.com/pi-hole/docker-pi-hole) | patch | `2025.11.0` -> `2025.11.1` | --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (jacklul/pihole)</summary> ### [`v2025.11.1`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.1) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.11.0...2025.11.1)  #### What's Changed (Docker Specific) - Fix build status badge in readme by [@nol166](https://redirect.github.com/nol166) in [#1938](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1938) - Add RISCV back by [@yubiuser](https://redirect.github.com/yubiuser) in [#1939](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1939) - Improve FTL startup detection and log tailing by [@PromoFaux](https://redirect.github.com/PromoFaux) in [#1940](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1940) - Set DNS listening mode to 'ALL' in docker-compose.yml example by [@cornshakes](https://redirect.github.com/cornshakes) in [#1946](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1946) - Add instructions for excluding Pi-hole from Watchtower updates by [@chippy01](https://redirect.github.com/chippy01) in [#1949](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1949) #### New Contributors - [@nol166](https://redirect.github.com/nol166) made their first contribution in [#1938](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1938) - [@cornshakes](https://redirect.github.com/cornshakes) made their first contribution in [#1946](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1946) - [@chippy01](https://redirect.github.com/chippy01) made their first contribution in [#1949](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1949) **Full Changelog**: <pi-hole/docker-pi-hole@2025.11.0...2025.11.1> ***  #### What's Changed (FTL v6.4.1) - Fix API specs and example for dns.upstreams in config.yaml by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/FTL#2696](https://redirect.github.com/pi-hole/FTL/pull/2696) - gravity update - silently discard unicode BOM if present by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/FTL#2702](https://redirect.github.com/pi-hole/FTL/pull/2702) - Update embedded SQLite to 3.51.0 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2704](https://redirect.github.com/pi-hole/FTL/pull/2704) - Get earliest query timestamp from database by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/FTL#2706](https://redirect.github.com/pi-hole/FTL/pull/2706) - Increase buffer length for query string by [@mwoolweaver](https://redirect.github.com/mwoolweaver) in [pi-hole/FTL#2709](https://redirect.github.com/pi-hole/FTL/pull/2709) - Reduce DNS resolver locking during database interaction by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2700](https://redirect.github.com/pi-hole/FTL/pull/2700) - Make colour output optional in streaming gravity API call by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/FTL#2718](https://redirect.github.com/pi-hole/FTL/pull/2718) - api/dhcp/leases Allow for hwaddr > 48 bits by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/FTL#2724](https://redirect.github.com/pi-hole/FTL/pull/2724) - Add rate-limiting for TOTP validation by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2719](https://redirect.github.com/pi-hole/FTL/pull/2719) - Implement simple partial matching for regex in /api/search/{domain} by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2705](https://redirect.github.com/pi-hole/FTL/pull/2705) - Performance optimizations: string processing, memory management, and compiler flags by [@Copilot](https://redirect.github.com/Copilot) in [pi-hole/FTL#2571](https://redirect.github.com/pi-hole/FTL/pull/2571) - Fix authentication redirect when webhome is / (fixes [#2518](https://redirect.github.com/pi-hole/docker-pi-hole/issues/2518)) by [@averyvigolo](https://redirect.github.com/averyvigolo) in [pi-hole/FTL#2610](https://redirect.github.com/pi-hole/FTL/pull/2610) - Reduce database locking and add timing debug setting by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2688](https://redirect.github.com/pi-hole/FTL/pull/2688) #### New Contributors - [@mwoolweaver](https://redirect.github.com/mwoolweaver) made their first contribution in [pi-hole/FTL#2709](https://redirect.github.com/pi-hole/FTL/pull/2709) - [@Copilot](https://redirect.github.com/Copilot) made their first contribution in [pi-hole/FTL#2571](https://redirect.github.com/pi-hole/FTL/pull/2571) - [@averyvigolo](https://redirect.github.com/averyvigolo) made their first contribution in [pi-hole/FTL#2610](https://redirect.github.com/pi-hole/FTL/pull/2610) **Full Changelog**: <pi-hole/FTL@v6.3.3...v6.4>   #### What's Changed (Web v6.4) - Start using commented tags for editorconfig-checker by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/web#3643](https://redirect.github.com/pi-hole/web/pull/3643) - Remove some unused code (leftover from v5) by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/web#3636](https://redirect.github.com/pi-hole/web/pull/3636) - Make sure the table is redrawn after the dnssec API call returns by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/web#3645](https://redirect.github.com/pi-hole/web/pull/3645) - Add hint that partial matching may not return all possible results by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/web#3654](https://redirect.github.com/pi-hole/web/pull/3654) - Enable one-time code autofill for TOTP input by [@sebastianlivoni](https://redirect.github.com/sebastianlivoni) in [pi-hole/web#3658](https://redirect.github.com/pi-hole/web/pull/3658) - Set "All Time " range for query log datepicker based on Database ranges (moment) by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/web#3657](https://redirect.github.com/pi-hole/web/pull/3657) - Request ANSI colour codes when calling gravity API by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/web#3662](https://redirect.github.com/pi-hole/web/pull/3662) - Pi-hole Web v6.4 by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/web#3670](https://redirect.github.com/pi-hole/web/pull/3670) #### New Contributors - [@sebastianlivoni](https://redirect.github.com/sebastianlivoni) made their first contribution in [pi-hole/web#3658](https://redirect.github.com/pi-hole/web/pull/3658) **Full Changelog**: <pi-hole/web@v6.3...v6.4> #### What's Changed (Core v6.3) - Add Fedora 43 to test suite by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/pi-hole#6453](https://redirect.github.com/pi-hole/pi-hole/pull/6453) - Fix libcap capabilities not being granted on OpenRC distros by [@Sparronator9999](https://redirect.github.com/Sparronator9999) in [pi-hole/pi-hole#6456](https://redirect.github.com/pi-hole/pi-hole/pull/6456) - systemd service - don't use deprecated PermissionsStartOnly by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/pi-hole#6465](https://redirect.github.com/pi-hole/pi-hole/pull/6465) - debug - speed up processing and display of file contents and services by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/pi-hole#6469](https://redirect.github.com/pi-hole/pi-hole/pull/6469) - Use port from dns.port in piholeDebug.sh by [@darkexplosiveqwx](https://redirect.github.com/darkexplosiveqwx) in [pi-hole/pi-hole#6475](https://redirect.github.com/pi-hole/pi-hole/pull/6475) - Improve gravity tables presentation on the debug log by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/pi-hole#6460](https://redirect.github.com/pi-hole/pi-hole/pull/6460) #### New Contributors - [@Sparronator9999](https://redirect.github.com/Sparronator9999) made their first contribution in [pi-hole/pi-hole#6456](https://redirect.github.com/pi-hole/pi-hole/pull/6456) **Full Changelog**: <pi-hole/pi-hole@v6.2.2...v6.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps).

…ag to v2025.11.1 This PR contains the following updates: | Package | Update | Change | |---|---|---| | [bigbeartechworld/big-bear-pihole-unbound](https://redirect.github.com/pi-hole/docker-pi-hole) | patch | `2025.11.0` → `2025.11.1` | --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (bigbeartechworld/big-bear-pihole-unbound)</summary> ### [`v2025.11.1`](https://redirect.github.com/pi-hole/docker-pi-hole/releases/tag/2025.11.1) [Compare Source](https://redirect.github.com/pi-hole/docker-pi-hole/compare/2025.11.0...2025.11.1)  ##### What's Changed (Docker Specific) - Fix build status badge in readme by [@nol166](https://redirect.github.com/nol166) in [#1938](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1938) - Add RISCV back by [@yubiuser](https://redirect.github.com/yubiuser) in [#1939](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1939) - Improve FTL startup detection and log tailing by [@PromoFaux](https://redirect.github.com/PromoFaux) in [#1940](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1940) - Set DNS listening mode to 'ALL' in docker-compose.yml example by [@cornshakes](https://redirect.github.com/cornshakes) in [#1946](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1946) - Add instructions for excluding Pi-hole from Watchtower updates by [@chippy01](https://redirect.github.com/chippy01) in [#1949](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1949) ##### New Contributors - [@nol166](https://redirect.github.com/nol166) made their first contribution in [#1938](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1938) - [@cornshakes](https://redirect.github.com/cornshakes) made their first contribution in [#1946](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1946) - [@chippy01](https://redirect.github.com/chippy01) made their first contribution in [#1949](https://redirect.github.com/pi-hole/docker-pi-hole/pull/1949) **Full Changelog**: <pi-hole/docker-pi-hole@2025.11.0...2025.11.1> ***  ##### What's Changed (FTL v6.4.1) - Fix API specs and example for dns.upstreams in config.yaml by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/FTL#2696](https://redirect.github.com/pi-hole/FTL/pull/2696) - gravity update - silently discard unicode BOM if present by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/FTL#2702](https://redirect.github.com/pi-hole/FTL/pull/2702) - Update embedded SQLite to 3.51.0 by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2704](https://redirect.github.com/pi-hole/FTL/pull/2704) - Get earliest query timestamp from database by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/FTL#2706](https://redirect.github.com/pi-hole/FTL/pull/2706) - Increase buffer length for query string by [@mwoolweaver](https://redirect.github.com/mwoolweaver) in [pi-hole/FTL#2709](https://redirect.github.com/pi-hole/FTL/pull/2709) - Reduce DNS resolver locking during database interaction by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2700](https://redirect.github.com/pi-hole/FTL/pull/2700) - Make colour output optional in streaming gravity API call by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/FTL#2718](https://redirect.github.com/pi-hole/FTL/pull/2718) - api/dhcp/leases Allow for hwaddr > 48 bits by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/FTL#2724](https://redirect.github.com/pi-hole/FTL/pull/2724) - Add rate-limiting for TOTP validation by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2719](https://redirect.github.com/pi-hole/FTL/pull/2719) - Implement simple partial matching for regex in /api/search/{domain} by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2705](https://redirect.github.com/pi-hole/FTL/pull/2705) - Performance optimizations: string processing, memory management, and compiler flags by [@Copilot](https://redirect.github.com/Copilot) in [pi-hole/FTL#2571](https://redirect.github.com/pi-hole/FTL/pull/2571) - Fix authentication redirect when webhome is / (fixes [#2518](https://redirect.github.com/pi-hole/docker-pi-hole/issues/2518)) by [@averyvigolo](https://redirect.github.com/averyvigolo) in [pi-hole/FTL#2610](https://redirect.github.com/pi-hole/FTL/pull/2610) - Reduce database locking and add timing debug setting by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/FTL#2688](https://redirect.github.com/pi-hole/FTL/pull/2688) ##### New Contributors - [@mwoolweaver](https://redirect.github.com/mwoolweaver) made their first contribution in [pi-hole/FTL#2709](https://redirect.github.com/pi-hole/FTL/pull/2709) - [@Copilot](https://redirect.github.com/Copilot) made their first contribution in [pi-hole/FTL#2571](https://redirect.github.com/pi-hole/FTL/pull/2571) - [@averyvigolo](https://redirect.github.com/averyvigolo) made their first contribution in [pi-hole/FTL#2610](https://redirect.github.com/pi-hole/FTL/pull/2610) **Full Changelog**: <pi-hole/FTL@v6.3.3...v6.4>   ##### What's Changed (Web v6.4) - Start using commented tags for editorconfig-checker by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/web#3643](https://redirect.github.com/pi-hole/web/pull/3643) - Remove some unused code (leftover from v5) by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/web#3636](https://redirect.github.com/pi-hole/web/pull/3636) - Make sure the table is redrawn after the dnssec API call returns by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/web#3645](https://redirect.github.com/pi-hole/web/pull/3645) - Add hint that partial matching may not return all possible results by [@DL6ER](https://redirect.github.com/DL6ER) in [pi-hole/web#3654](https://redirect.github.com/pi-hole/web/pull/3654) - Enable one-time code autofill for TOTP input by [@sebastianlivoni](https://redirect.github.com/sebastianlivoni) in [pi-hole/web#3658](https://redirect.github.com/pi-hole/web/pull/3658) - Set "All Time " range for query log datepicker based on Database ranges (moment) by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/web#3657](https://redirect.github.com/pi-hole/web/pull/3657) - Request ANSI colour codes when calling gravity API by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/web#3662](https://redirect.github.com/pi-hole/web/pull/3662) - Pi-hole Web v6.4 by [@PromoFaux](https://redirect.github.com/PromoFaux) in [pi-hole/web#3670](https://redirect.github.com/pi-hole/web/pull/3670) ##### New Contributors - [@sebastianlivoni](https://redirect.github.com/sebastianlivoni) made their first contribution in [pi-hole/web#3658](https://redirect.github.com/pi-hole/web/pull/3658) **Full Changelog**: <pi-hole/web@v6.3...v6.4> ##### What's Changed (Core v6.3) - Add Fedora 43 to test suite by [@yubiuser](https://redirect.github.com/yubiuser) in [pi-hole/pi-hole#6453](https://redirect.github.com/pi-hole/pi-hole/pull/6453) - Fix libcap capabilities not being granted on OpenRC distros by [@Sparronator9999](https://redirect.github.com/Sparronator9999) in [pi-hole/pi-hole#6456](https://redirect.github.com/pi-hole/pi-hole/pull/6456) - systemd service - don't use deprecated PermissionsStartOnly by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/pi-hole#6465](https://redirect.github.com/pi-hole/pi-hole/pull/6465) - debug - speed up processing and display of file contents and services by [@rrobgill](https://redirect.github.com/rrobgill) in [pi-hole/pi-hole#6469](https://redirect.github.com/pi-hole/pi-hole/pull/6469) - Use port from dns.port in piholeDebug.sh by [@darkexplosiveqwx](https://redirect.github.com/darkexplosiveqwx) in [pi-hole/pi-hole#6475](https://redirect.github.com/pi-hole/pi-hole/pull/6475) - Improve gravity tables presentation on the debug log by [@rdwebdesign](https://redirect.github.com/rdwebdesign) in [pi-hole/pi-hole#6460](https://redirect.github.com/pi-hole/pi-hole/pull/6460) ##### New Contributors - [@Sparronator9999](https://redirect.github.com/Sparronator9999) made their first contribution in [pi-hole/pi-hole#6456](https://redirect.github.com/pi-hole/pi-hole/pull/6456) **Full Changelog**: <pi-hole/pi-hole@v6.2.2...v6.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/bigbeartechworld/big-bear-universal-apps).

averyvigolo requested a review from a team as a code owner August 24, 2025 17:39

averyvigolo changed the title ~~Only use redirect_root_handler if webhome is set (fixes #2518)~~ Fix authentication redirect when webhome is / (fixes #2518) Sep 7, 2025

DL6ER reviewed Sep 14, 2025

View reviewed changes

Comment thread src/webserver/webserver.c Outdated

averyvigolo force-pushed the fix_auth_redirect branch from 14311f1 to 73837dc Compare September 21, 2025 12:12

averyvigolo force-pushed the fix_auth_redirect branch from 73837dc to eace39c Compare October 30, 2025 19:13

DL6ER approved these changes Nov 25, 2025

View reviewed changes

DL6ER enabled auto-merge November 25, 2025 19:19

DL6ER merged commit dc3a5fa into pi-hole:development Nov 25, 2025
13 checks passed

PromoFaux mentioned this pull request Nov 27, 2025

Pi-hole FTL v6.4 #2726

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix authentication redirect when webhome is / (fixes #2518)#2610

Fix authentication redirect when webhome is / (fixes #2518)#2610
DL6ER merged 1 commit into
pi-hole:developmentfrom
averyvigolo:fix_auth_redirect

averyvigolo commented Aug 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

DL6ER commented Oct 30, 2025

Uh oh!

averyvigolo commented Oct 30, 2025

Uh oh!

Uh oh!

pralor-bot commented Nov 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

averyvigolo commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

DL6ER commented Oct 30, 2025

Uh oh!

averyvigolo commented Oct 30, 2025

Uh oh!

Uh oh!

pralor-bot commented Nov 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

averyvigolo commented Aug 24, 2025 •

edited

Loading