Pi-hole FTL v6.4#2726
Merged
Merged
Conversation
…, and compiler flags Co-authored-by: DL6ER <16748619+DL6ER@users.noreply.github.com>
Signed-off-by: Dominik <dl6er@dl6er.de>
This fixes an infinite redirect on the home page when authentication is enabled. The redirects are caused by XHR calls to the API, which receive a 401 response, and the error handlers simply reload the page. If webhome is not set, the default request handler should be used to properly handle authentication. So, conditionally enable redirect_root_handler, if webhome is not empty or `/`. This fixes the problem, as there's an immediate redirect to /login, before any XHR calls. Remove the initial fix in #2521, as it is no longer necessary. That fix involved checking in redirect_root_handler, if the redirect destination is the same as the request URI. Signed-off-by: averyvigolo <avery@averyv.me>
…DB thread Signed-off-by: Dominik <dl6er@dl6er.de>
Signed-off-by: Dominik <dl6er@dl6er.de>
Sync master back into development
Replace "dnsmasq/upstreams" with the correct "dns/upstreams" Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Update comments to use the correct options (`config/dns` instead of `config/dnsmasq`) on the examples Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Co-authored-by: Dominik <DL6ER@users.noreply.github.com> Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
…pdates Bumps the github_action-dependencies group with 2 updates in the / directory: [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) and [codespell-project/actions-codespell](https://github.com/codespell-project/actions-codespell). Updates `docker/setup-qemu-action` from 3.6.0 to 3.7.0 - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@2910929...c7c5346) Updates `codespell-project/actions-codespell` from 2.1 to 2.2 - [Release notes](https://github.com/codespell-project/actions-codespell/releases) - [Commits](codespell-project/actions-codespell@406322e...8f01853) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-version: 3.7.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_action-dependencies - dependency-name: codespell-project/actions-codespell dependency-version: '2.2' dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_action-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Fix API specs and example for dns.upstreams in config.yaml
… inside a TRANSACTION Signed-off-by: Dominik <dl6er@dl6er.de>
…opment-github_action-dependencies-e02ba4420f Bump the github_action-dependencies group across 1 directory with 2 updates
… inside a TRANSACTION Signed-off-by: Dominik <dl6er@dl6er.de>
…ean speedup espectially when only few entries are exported (typical case) Signed-off-by: Dominik <dl6er@dl6er.de>
Some adlists in UTF-8 may contain unnecessary unicode BOM at the start of the file. This change silently discards these, if present, instead of flagging them as non-domain entries. Signed-off-by: Rob Gill <rrobgill@protonmail.com>
gravity update - silently discard unicode BOM if present
Signed-off-by: Dominik <dl6er@dl6er.de>
…re now native parts of the amalgation build. Signed-off-by: Dominik <dl6er@dl6er.de>
…ll only work for literal parts of regular expressions and will not find complicated regular expressions Signed-off-by: Dominik <dl6er@dl6er.de>
the earliest timestamp found in the database. Also gets number of queries/earliest timestamp in on-disk database Useful for determining the "All Time" range on the web interface Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Update embedded SQLite to 3.51.0
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Get earliest query timestamp from database
…e read operations Signed-off-by: Dominik <dl6er@dl6er.de>
Signed-off-by: Michael Woolweaver <michael@woolweaver.bid>
Increase buffer length for query string
…pdates Bumps the github_action-dependencies group with 2 updates in the / directory: [softprops/action-gh-release](https://github.com/softprops/action-gh-release) and [github/codeql-action](https://github.com/github/codeql-action). Updates `softprops/action-gh-release` from 2.4.1 to 2.4.2 - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@6da8fa9...5be0e66) Updates `github/codeql-action` from 4.31.2 to 4.31.3 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@0499de3...014f16e) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-version: 2.4.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_action-dependencies - dependency-name: github/codeql-action dependency-version: 4.31.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_action-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…opment-github_action-dependencies-8937ba49c4 Bump the github_action-dependencies group across 1 directory with 2 updates
The gravity action endpoint now only includes ANSI escape codes when the client explicitly requests them via the 'color=true' query parameter. This prevents ANSI codes from appearing in API responses for consumers that don't need them, fixing issue #2671. The web interface will request colors by adding '?color=true' to its API call. Other API consumers will receive plain output by default. Addresses: #2671
Signed-off-by: Dominik <dl6er@dl6er.de>
Reduce DNS resolver locking during database interaction
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Make colour output optional in streaming gravity API call
…pdates Bumps the github_action-dependencies group with 2 updates in the / directory: [actions/checkout](https://github.com/actions/checkout) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/checkout` from 5.0.0 to 6.0.0 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@08c6903...1af3b93) Updates `github/codeql-action` from 4.31.3 to 4.31.4 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@014f16e...e12f017) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github_action-dependencies - dependency-name: github/codeql-action dependency-version: 4.31.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_action-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…opment-github_action-dependencies-9acab48073 Bump the github_action-dependencies group across 1 directory with 2 updates
Adjust buffer and string formatting capability for hwaddr up to 16 octets in length, as per rfc2131 https://www.rfc-editor.org/rfc/rfc2131#section-2 Signed-off-by: Rob Gill <rrobgill@protonmail.com>
Signed-off-by: Dominik <dl6er@dl6er.de>
api/dhcp/leases Allow for hwaddr > 48 bits
Add rate-limiting for TOTP validation
Implement simple partial matching for regex in /api/search/{domain}
…b094-28ab67b1773a Performance optimizations: string processing, memory management, and compiler flags
Fix authentication redirect when webhome is / (fixes #2518)
Reduce database locking and add timing debug setting
yubiuser
approved these changes
Nov 26, 2025
DL6ER
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
webserver.paths.webhometo/causes an infinite redirect when accessing pi.hole #2518) by @averyvigolo in Fix authentication redirect when webhome is / (fixes #2518) #2610New Contributors
Full Changelog: v6.3.3...v6.4