Skip to content

Fix URL parsing in gravity.sh - #6689

Open
rdwebdesign wants to merge 1 commit into
developmentfrom
fix/gravity_awk
Open

rdwebdesign wants to merge 1 commit into
developmentfrom
fix/gravity_awk

Conversation

@rdwebdesign

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?

Fix awk command to return the domain even when there is a "@" character in the middle of the URL: "http://domain.com/path@version/file.txt"

The new command first removes the protocol, then removes the "@" character, but only when it appears in the first part, before the domain: "http://username:password@domain.com/file.txt"

The old command removed everything (including the actual domain) before the "@" character, unconditionally.

Fix #6685

How does this PR accomplish the above?

Changing the awk command to use 2 separate gsub calls. One for the protocol and another one to filter credentials. The new command uses a different regex, that removes text only when the "@" character appears before the domain.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Fix awk command to return the domain even when there is a "@" character in
the middle of the URL: "http://domain.com/path@version/file.txt"

The new command first removes the protocol, then removes the "@" character,
but only when it appears in the first part, before the domain:
"http://username:password@domain.com/file.txt"

The old command removed everything (including the actual domain) before the
"@" character, unconditionally.

Fix #6685

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign
rdwebdesign requested a review from a team as a code owner August 27, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant