Conversation
intelfx
marked this pull request as ready for review
November 13, 2025 12:00
intelfx
force-pushed
the
work/oauth
branch
6 times, most recently
from
November 13, 2025 13:39
b25f491 to
af1ed06
Compare
|
This would be of great use. When can this PR be approved? |
|
I would love to use this! could we get the PR looked at? <3 |
Member
Author
|
This will eventually happen, sorry everyone. We are all exceedingly busy with work on upcoming features and products. |
Add a sentinel marker `yamlconf.Dynamic()` that can be used as a schema key to signal a schema applying to an arbitrary number of keys at this level.
If the schema definition at a given level has a `Dynamic` marker key, validate every key that is not otherwise present in the schema against the definition of that key. Further down the line, we can make unexpected extra keys illegal, but for that we need to sanitize a;; existing uses of dynamic content.
`self.__states` is a list of states rather than a map of keys to states, so it does not make sense to attempt to `pop()` the state key.
If the session state key was not present in the session state registry at all (as opposed to being present as part of an invalid session), we'd return True. Do not do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary implementation of a pluggable authentication flow architecture, with the OAuth/OAuth2 backend as the first user thereof.
Credits: #156
This implementation accepts configuration under the
kvmd.auth.flows.oauthkey, as follows:UI-wise, each provider corresponds to a separate button on the login page which triggers the corresponding auth flow.
API-wise, the new APIs are located under
/api/auth/flow/oauth/{key}. The name of a section underkvmd.auth.flows.oauth.providers(e.g.,githubormicrosoft) is an arbitrary URL-safe string, and it is used as the{key}in the base URL above.The callback URL will be
{pi-kvm}/api/auth/flow/oauth/{key}/callback. You will have to whitelist that URL in the OAuth authorization server in use.