Run TestVideo.test_basic with xfail on Windows - #1526
Merged
sergey-mkhitaryan merged 1 commit intoAug 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Windows behavior of TestVideo.test_basic so the test is executed (rather than skipped) while preventing Windows CI failures from blocking merges, enabling easier debugging of the failure.
Changes:
- Replace
@pytest.mark.skipif(platform.system() == 'Windows', ...)with@pytest.mark.xfail(..., strict=False)forTestVideo.test_basic.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+85
to
90
| @pytest.mark.xfail( | ||
| platform.system() == 'Windows', | ||
| reason='PXT-1295: TestVideo.test_basic[proxy] consistently fails on Windows in CI', | ||
| strict=False, | ||
| ) | ||
| def test_basic(self, make_catalog_path: Callable[[str], str]) -> None: |
sergey-mkhitaryan
marked this pull request as ready for review
August 14, 2026 05:37
sergey-mkhitaryan
requested review from
aaron-siegel and
mkornacker
as code owners
August 14, 2026 05:37
aaron-siegel
approved these changes
Aug 14, 2026
sergey-mkhitaryan
enabled auto-merge
August 14, 2026 08:05
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test will be run, but any outcome will be ignored. This should enable us to debug it.