Skip to content

Fix audio halting loading in IE - #437

Merged
vkalpias merged 1 commit into
masterfrom
feature/ie-audio-fix
Nov 16, 2015
Merged

vkalpias merged 1 commit into
masterfrom
feature/ie-audio-fix

Conversation

@vkalpias

Copy link
Copy Markdown
Collaborator

No description provided.

vkalpias added a commit that referenced this pull request Nov 16, 2015
@vkalpias
vkalpias merged commit 29a0624 into master Nov 16, 2015
@vkalpias
vkalpias deleted the feature/ie-audio-fix branch November 16, 2015 15:18
Comment thread src/audio/audio_sound.js

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can pre-cache result of this function, as userAgent does not changes in real-time.
So you wont run it on every audio element added. As doing indexOf of relatively long userAgent, can be costly for real-time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants