Skip to content

fix: normalize Binance ticker symbols - #2421

Open
AnuragR3k wants to merge 1 commit into
pmxt-dev:mainfrom
AnuragR3k:fix/binance-feed-symbol-case
Open

fix: normalize Binance ticker symbols#2421
AnuragR3k wants to merge 1 commit into
pmxt-dev:mainfrom
AnuragR3k:fix/binance-feed-symbol-case

Conversation

@AnuragR3k

@AnuragR3k AnuragR3k commented Sep 22, 2026

Copy link
Copy Markdown

What changed

Fixes #2415.

  • Normalize Binance symbols to uppercase when checking the ticker cache.
  • Normalize symbols when registering ticker subscriptions.
  • Add regression tests for lowercase btc/usdt with fetchTicker and watchTicker.

Validation

  • npm test -- dataFeeds.core.test.ts
  • npm run --workspace=pmxt-core build
  • git diff --check

@AnuragR3k AnuragR3k mentioned this pull request Sep 22, 2026
Open

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BinanceFeed doesn't normalize symbol case — fetchTicker/watchTicker silently hang then time out for non-canonical-case symbols

1 participant

@AnuragR3k