Skip to content

Fix/Update polarisfs.base_path with version number#189

Merged
zhu0619 merged 4 commits into
mainfrom
fix/base_path
Sep 3, 2024
Merged

Fix/Update polarisfs.base_path with version number#189
zhu0619 merged 4 commits into
mainfrom
fix/base_path

Conversation

@zhu0619

@zhu0619 zhu0619 commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

Changelogs

  • Updated polarisfs.base_path by adding version v1.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

discussion related to that PR

@zhu0619 zhu0619 requested a review from cwognum as a code owner September 3, 2024 19:01
@zhu0619 zhu0619 requested review from jstlaurent and removed request for cwognum September 3, 2024 19:02

@jstlaurent jstlaurent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, but ok to merge when they are addressed.

Comment thread polaris/hub/polarisfs.py Outdated
Comment thread polaris/hub/client.py
zhu0619 and others added 2 commits September 3, 2024 15:28
Remove leftover debug logs.

Co-authored-by: Julien St-Laurent <jstlaurent@users.noreply.github.com>
@zhu0619 zhu0619 changed the title Fix/base path Fix/Update polarisfs.base_path woth version number Sep 3, 2024
@zhu0619 zhu0619 merged commit 9634268 into main Sep 3, 2024
@zhu0619 zhu0619 deleted the fix/base_path branch September 3, 2024 19:58
@zhu0619 zhu0619 changed the title Fix/Update polarisfs.base_path woth version number Fix/Update polarisfs.base_path with version number Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants