Skip to content

Fix/Update polarisfs.base_path with version number #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhu0619 merged 4 commits into from
Sep 3, 2024
Merged

Fix/Update polarisfs.base_path with version number #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25fc326
update base_path
zhu0619 Sep 3, 2024
fbe64e1
remove duplicated exception
zhu0619 Sep 3, 2024
ffc9525
Update polaris/hub/polarisfs.py
zhu0619 Sep 3, 2024
88b1438
restore exception
zhu0619 Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions polaris/hub/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,7 @@ def open_zarr_file(
except HTTPStatusError as error:
# In this case, we can pass the response to provide more information
raise PolarisHubError(message="Error opening Zarr store", response=error.response) from error
# This catches all other types of exceptions
except Exception as error:
raise PolarisHubError(message="Error opening Zarr store") from error

Expand Down
3 changes: 2 additions & 1 deletion polaris/hub/polarisfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ def __init__(

# Prefix to remove from ls entries
self.prefix = f"dataset/{dataset_owner}/{sluggify(dataset_name)}/"
self.base_path = f"/storage/{self.prefix.rstrip('/')}"
# Base path for uploading. Please pay attention on path version update.
self.base_path = f"/v1/storage/{self.prefix.rstrip('/')}"

@staticmethod
def is_polarisfs_path(path: str) -> bool:
Expand Down