Conversation
It might sound unneccesary to base64-encode plaintext attachments, but some smtp providers modify them otherwise
pajowu
force-pushed
the
pajowu/mail_attachment_always_b64
branch
from
August 13, 2026 11:18
39563af to
cfeb7a6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6476 +/- ##
==========================================
- Coverage 78.81% 78.81% -0.01%
==========================================
Files 482 482
Lines 70520 70533 +13
==========================================
+ Hits 55581 55589 +8
- Misses 14939 14944 +5
🚀 New features to boost your workflow:
|
raphaelm
approved these changes
Sep 10, 2026
| def _create_mime_attachment(self, content, mimetype): | ||
| """ | ||
| Convert the content, mimetype pair into a MIME attachment object. | ||
|
|
Member
There was a problem hiding this comment.
Maybe add a "why" to this comment for the future?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might sound unneccesary to base64-encode plaintext attachments, but some smtp providers modify them otherwise