Repository navigation
fix: compare integer64 logical tweaks by value - #532
Open
LeonidasZhak wants to merge 8 commits into
Open
LeonidasZhak wants to merge 8 commits into
LeonidasZhak wants to merge 8 commits into
Conversation
LeonidasZhak
force-pushed
the
fix/logical-return-integer64-308
branch
from
September 25, 2026 15:17
3540127 to
42815b5
Compare
Contributor
Formatting suggestions availableA patch file with formatting suggestions has been generated. You can apply it using one of these methods: Method 1: Apply via gh CLI# Download and apply the patch directly
gh run download 36153182749 --repo r-dbi/DBItest --name changes-patch && patch -p1 < changes.patch && rm changes.patchRepo owners can also apply the patch automatically. Click the button to jump to the comment box, then post: Method 2: View the patchClick to see the patch contentsdiff --git a/man/spec_arrow_write_table_arrow.Rd b/man/spec_arrow_write_table_arrow.Rd
index 0aebe9c8..cf76e061 100644
--- a/man/spec_arrow_write_table_arrow.Rd
+++ b/man/spec_arrow_write_table_arrow.Rd
@@ -20,7 +20,9 @@ or invalid connection.
An error is also raised
if \code{name} cannot be processed with \code{\link[DBI:dbQuoteIdentifier]{dbQuoteIdentifier()}} or
if this results in a non-scalar.
-Invalid values for the additional arguments \code{overwrite}, \code{append}, and \code{temporary} (non-scalars,
+Invalid values for the additional arguments
+\code{overwrite}, \code{append}, and \code{temporary}
+(non-scalars,
unsupported data types,
\code{NA},
incompatible values,
This comment was automatically generated by the commit-suggester workflow. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore this PR to a reviewable state on current
mainwhile keeping the originaldata_logicalfix narrow.Thanks to maintainers
Thanks for maintaining
DBItest, and for the earlier discussion in#308and#309about keepinglogical_returnnarrowly scoped.Issue or motivation
data_logicalstill failed for alogical_returntweak that returnsbit64::integer64values, including the list-returning form discussed in#309. After this branch was refreshed against currentmain, the restored CI workflows also could not resolve the existingconstructiveSuggests dependency from the default CRAN/RSPM repository set.Root cause
The original spec compared fetched values with
expect_identical(), so a backend returning1L/0Ldid not matchbit64::integer64logical-return expectations despite representing the same logical values. Separately, the generated stream-bind specs needed explicitstringsAsFactors = FALSEfor character bind-value data frames. The later CI failures were dependency metadata failures:constructiveis used by the package, but the GitHub Actions dependency solve runs under a repository override that does not include the package source.Change
data_logicalexpectations into scalar predicates that compare by logical value.logical_returntweaks forbit64::integer64values.stringsAsFactors = FALSE.maininto this PR branch so the restored workflows and version bump from#574/#575are included.https://cynkra.r-universe.devas anAdditional_repositoriesentry, and passcynkra/constructiveto the CI dependency setup paths that otherwise ignore that repository during the initial solve.Tests
Latest refresh on current PR head
13b43f7c:RENV_CONFIG_REPOS_OVERRIDE='https://packagemanager.posit.co/cran/__linux__/noble/latest' Rscript -e 'pak::lockfile_create(c("deps::.", "any::sessioninfo", "r-lib/lintr", "local::.", "cynkra/constructive"), dependencies = c("Config/Needs/lint", "all"))'— pass.RENV_CONFIG_REPOS_OVERRIDE='https://packagemanager.posit.co/cran/__linux__/noble/latest' Rscript -e 'pak::lockfile_create(c("deps::.", "any::sessioninfo", "any::rcmdcheck", "r-lib/roxygen2", "any::decor", "r-lib/pkgdown", "r-lib/covr", "any::xml2", "any::rmarkdown", "cynkra/cynkratemplate", "deps::.", "cynkra/constructive"), dependencies = c("Config/Needs/build", "Config/Needs/check", "Config/Needs/website", "Config/Needs/roxygen2", "all"))'— pass.RENV_CONFIG_REPOS_OVERRIDE='https://packagemanager.posit.co/cran/__linux__/noble/latest' Rscript -e 'pak::lockfile_create(c("deps::.", "any::sessioninfo", "any::pkgbuild", "any::remotes", "decor", ".", "cynkra/constructive"), dependencies = c("Config/Needs/check", "all"))'— pass.git diff --check origin/main...HEAD— pass.Rscript -e 'lintr::lint_package()'— pass, no lints found; local config warns thatexpect_shape_linteris not in current defaults.Rscript -e 'testthat::test_file("tests/testthat/test-logical-return.R", reporter = "summary")'— pass, 62 assertions.Rscript -e 'testthat::test_local(reporter = "summary")'— pass, 9693 passed, 64 skipped, 0 failed.R CMD build .— pass, builtDBItest_1.8.3.9012.tar.gzfrom a fresh temporary directory._R_CHECK_CRAN_INCOMING_REMOTE_=false R CMD check --as-cran DBItest_1.8.3.9012.tar.gz— pass with 2 NOTEs: development version number and local HTML Tidy not recent enough for HTML validation.Scope
This stays within the
data_logicalroundtrip spec, generated bind-spec alignment, CI dependency resolution for an existing Suggests package, and branch sync needed to keep this PR reviewable. It does not change broader integer64 comparison behavior, backend workflow design, backend-specific test semantics, or other bigint-related specs such as#311or#412.