Remove obsolete user created_at guard - #6862
Open
colby-swandale wants to merge 1 commit into
Open
colby-swandale wants to merge 1 commit into
colby-swandale wants to merge 1 commit into
Conversation
colby-swandale
added this pull request to stack #6863
September 21, 2026 06:20
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6862 +/- ##
==========================================
- Coverage 97.84% 97.84% -0.01%
==========================================
Files 538 538
Lines 11947 11945 -2
==========================================
- Hits 11689 11687 -2
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
brian-penguin
approved these changes
Sep 21, 2026
Co-authored-by: Amp <amp@ampcode.com>
colby-swandale
force-pushed
the
colby/remove-user-created-at-guard
branch
from
September 21, 2026 21:07
8d48aa1 to
fbd3505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User#log_actor_attributesto requirecreated_atwhen calculating account agecreated_atis missingStacked on #6861, which must be deployed and its maintenance task completed before this change is deployed.
Testing
bin/rubocop --format simple --force-exclusion -- app/models/user.rb test/models/user_test.rbbin/rails test test/tasks/maintenance/backfill_user_created_at_task_test.rbbin/rails test test/integration/request_log_payload_test.rb:116bin/rails test test/models/user_test.rbCo-authored-by: Amp amp@ampcode.com
Stack created with GitHub Stacks CLI • Give Feedback 💬