-
Notifications
You must be signed in to change notification settings - Fork 24
Avoid attempting to read /etc/(?:os | lsb)-release on Android
#164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I noticed the Android tests were failing non-deterministically, in different tests, so assumed it was some kind of poor timing/concurrency issue in the emulator, changing to running Android tests sequentially with |
Oh thank you! That's something that blocked #151 from landing, because we didn't know if it was the PR's fault or something pre-existing. |
gabrielesvelto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit but the rest is fine, thanks for all the cleanups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
Damn, looks like I didn't actually fix the Android tests. I think it's the linux gate and mapping test that often fail, and it feels like it's not our fault, so maybe we just disable those tests for android only? |
Yes, let's file an issue to investigate it later. It's not a big deal anyway. |
Resolves: #163