Skip to content

Conversation

@Jake-Shadle
Copy link
Collaborator

Resolves: #163

@Jake-Shadle
Copy link
Collaborator Author

I noticed the Android tests were failing non-deterministically, in different tests, so assumed it was some kind of poor timing/concurrency issue in the emulator, changing to running Android tests sequentially with -j 1 seems to make it behave.

@gabrielesvelto
Copy link
Contributor

I noticed the Android tests were failing non-deterministically, in different tests, so assumed it was some kind of poor timing/concurrency issue in the emulator, changing to running Android tests sequentially with -j 1 seems to make it behave.

Oh thank you! That's something that blocked #151 from landing, because we didn't know if it was the PR's fault or something pre-existing.

Copy link
Contributor

@gabrielesvelto gabrielesvelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit but the rest is fine, thanks for all the cleanups

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Jake-Shadle
Copy link
Collaborator Author

Damn, looks like I didn't actually fix the Android tests. I think it's the linux gate and mapping test that often fail, and it feels like it's not our fault, so maybe we just disable those tests for android only?

@gabrielesvelto
Copy link
Contributor

Damn, looks like I didn't actually fix the Android tests. I think it's the linux gate and mapping test that often fail, and it feels like it's not our fault, so maybe we just disable those tests for android only?

Yes, let's file an issue to investigate it later. It's not a big deal anyway.

@Jake-Shadle Jake-Shadle merged commit 11ecbd7 into main Dec 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't try to read the Linux distribution information on Android

3 participants