Use the debugger rendez-vous to populate the module list on Linux#151
Use the debugger rendez-vous to populate the module list on Linux#151marti4d wants to merge 2 commits intorust-minidump:mainfrom
Conversation
|
@gabrielesvelto @Jake-Shadle You're going to want to review only ea7b747. The other two commits are from the other two open PRs. |
|
Gonna review this ASAP. Thank you @marti4d |
|
BTW we might want to add a "validation" step to the list of modules we've generated, to spot problematic cases like those we encountered in the wild. For example, if we find two modules with the same name but different debug IDs. |
fcd1ac4 to
350da9b
Compare
gabrielesvelto
left a comment
There was a problem hiding this comment.
Mostly stylistic/readability changes but I was also curious about the hard-coded page size in the code.
|
@marti4d do you want to double-check the Android failures or shall I merge? |
|
I am going to spend some time trying to look into them, but it's weird. I don't see the issue in my local emulator, or on real Android devices. So it makes me wonder if there's something going on with CI, or if the emulator is just running too slow on weak hardware? Either way, maybe I should try even more to figure it out before we merge. |
fee5874 to
87483da
Compare
Fixes #142