Fix several errors in failure handling #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces a code 21 failure by the proper code 26 (branch to alternate with permanent loss in safety). Fixes raceintospace#445.
Fixes missing AltD entries for the EARTH ORBITAL-LEX mission, leading to abrupt mission ending in case of deadly LM failures. Fixes raceintospace#527.
Changes the manned space mission milestone being awarded on re-entry instead of recovery/landing. This causes launch aborts requiring recovery no longer count as a manned suborbital and ensures that certain minor failures on recovery can no longer invalidate prestige awards. Also updates the mission.dat entry for the manned suborbital to have no alternate step defined on re-entry, as it is the case with all other manned missions. Fixes raceintospace#330.
Changes a minishuttle launch failure from code 7 to 24, preventing the mission to continue. Fixes raceintospace#530.
Moves the failure "SUIT MALFUNCTION, COOLANT SYSTEM IS BROKEN. EVA IS SCRUBBED. EVA SUIT SAFETY FACTOR IS REDUCED BY 20%." from code 7 to code 26, ensuring that the equipment is damaged and the step is marked as a failure. Updates the information about the damage, as code 26 failures no longer lead to constant safety factor reductions. Fixes raceintospace#537.
Moves the lunar orbital prestige from lunar orbital activities to lunar orbital ins burn (analogous to the manned earth orbital) and make this step valid for prestige evaluation when on an alternate branch. This means that a docking failure while travelling to the moon on an LM test mission will no longer deny the lunar orbital prestige. Also fixes an error in the prestige calculation that did not take the actual mission steps into account. Fixes raceintospace#322.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add launch abort for code 7 failures (fixes Launch abort teleports capsule into space #530)