Repository navigation
Deprecate SafeBuffer#clone_empty - #48264
Merged
guilleiguaran merged 1 commit intoMay 21, 2023
Merged
guilleiguaran merged 1 commit into
guilleiguaran merged 1 commit into
Conversation
This method is unused within the Rails codebase, the last caller was removed by 479c7ca in 2014 (Rails 4.2.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
SafeBuffer#clone_emptyis unused within the Rails codebase. The last caller was removed by 479c7ca in 2014 (Rails 4.2.0).Additional information
A search on github suggests that this method isn't called often by any public code written or updated in the last 11 years.
Is this a method we want to continue to support?
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]