RavenDB-27557 Collapse @system collection group by default - #23659
Open
mateuszbartosik wants to merge 2 commits into
Open
mateuszbartosik wants to merge 2 commits into
mateuszbartosik wants to merge 2 commits into
Conversation
Replace the ko if with a CSS grid wrapper so the group animates open/closed, and rotate a single chevron instead of swapping icons.
M4xymm
approved these changes
Sep 18, 2026
kalczur
suggested changes
Sep 18, 2026
Comment on lines
+275
to
+277
| @media (prefers-reduced-motion: reduce) { | ||
| transition: none; | ||
| } |
Contributor
There was a problem hiding this comment.
Can't we specify it globally?
Contributor
Author
There was a problem hiding this comment.
Done in e4e12b0.
There was nothing global to hook into — $enable-reduced-motion was overridden to
false in bs5variables.scss, while Bootstrap's own default is true. Restored
it and put the rule at the top level of _bs5.scss. It has to sit outside the
.bs5 { } block, otherwise it compiles to .bs5 * and never reaches #main-menu.
0.01ms rather than none is deliberate — we have transitionend /
animationend listeners in notificationCenter.ts and viewHelpers.ts.
Restore Bootstrap's own $enable-reduced-motion default instead of
overriding it to false, and add the rule at the top level of _bs5.scss so
individual components no longer need to guard their own transitions.
It has to sit outside the `.bs5 { }` block: _reboot.scss is imported
inside it, which would scope the rule to `.bs5 *` and never reach
#main-menu, which is imported outside that block.
Durations collapse to 0.01ms rather than none so that transitionend and
animationend listeners still fire.
mateuszbartosik
force-pushed
the
RavenDB-27557
branch
from
September 18, 2026 11:46
4d9ae82 to
e4e12b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RavenDB-27557
Additional description
The
@systemcollection group in the Studio sidebar now starts collapsed instead of expanded, and the toggle is animated.Collapsed by default
collectionsTracker.systemCollectionsExpandednow defaults tofalse. The state lives in memory on thecollectionsTrackersingleton and is not persisted, so it resets to collapsed on page reload (expanding it persists across database switches within a session, as before).Animated toggle
The group previously used
<!-- ko if: systemCollectionsExpanded -->, which removes the list from the DOM entirely — that makes an exit animation impossible. It is replaced with a wrapper that stays mounted and collapses viagrid-template-rows: 0fr -> 1fr:divis needed becauseoverflow: hiddendirectly on the<ul>would clip the tree-line::beforepseudo-elements, which sit atleft: -2px. The<ul>'s ownmargin-leftkeeps them inside the inner box.icon-arrow-filled-rightrotated 90deg rather than swapping betweenicon-arrow-filled-down/icon-arrow-filled-right, reusing thetransform 0.15s ease-outtransition already established for menu icons in_main-menu.scss.prefers-reduced-motion: reducedisables both transitions, matching the existing pattern in_reboot.scss,SegmentedControl.scssandAnalysisProgress.scss.Two small additions that came with keeping the list mounted:
aria-expandedon the group header, since the expanded state is now real DOM state.visibility: hiddenwhile collapsed, so the hidden collection links stay out of the tab order.No
motionusage here — the sidebar is Knockout, andmotionis only wired up in this codebase asmotion/react.Type of change
How risky is the change?
Backward compatibility
Is it platform specific issue?
Documentation update
Documentation Requiredtag.Testing by Contributor
private)Testing by RavenDB QA team
QA Requiredtag.Is there any existing behavior change of other features due to this change?
UI work
Studio Requiredtag.