[RayJob] Improve dashboard client log #1903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In #1835, we don't store logger into context for RayJob controller. #1894 calls ctrl.LoggerFrom, which retrieves a default logger containing metadata information about the controller and K8s resources. This PR stores the logger into context to keep the consistent logging format. In the future, we may need to add controller/CR metadata to the logger for better structured logging.
Related issue number
Checks