Skip to content

[RayJob] Improve dashboard client log #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevin85421 merged 1 commit into from
Feb 6, 2024
Merged

[RayJob] Improve dashboard client log #1903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ray-operator/controllers/ray/raycluster_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ type RayClusterReconcilerOptions struct {

// Reconcile used to bridge the desired state with the current state
func (r *RayClusterReconciler) Reconcile(ctx context.Context, request ctrl.Request) (ctrl.Result, error) {
var err error
ctx = ctrl.LoggerInto(ctx, r.Log) // TODO: add request namespace here
var err error

// Try to fetch the RayCluster instance
instance := &rayv1.RayCluster{}
Expand Down
1 change: 1 addition & 0 deletions ray-operator/controllers/ray/rayjob_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ func NewRayJobReconciler(mgr manager.Manager, dashboardClientFunc func() utils.R
// Automatically generate RBAC rules to allow the Controller to read and write workloads
// Reconcile used to bridge the desired state with the current state
func (r *RayJobReconciler) Reconcile(ctx context.Context, request ctrl.Request) (ctrl.Result, error) {
ctx = ctrl.LoggerInto(ctx, r.Log)
r.Log.Info("reconciling RayJob", "NamespacedName", request.NamespacedName)

// Get RayJob instance
Expand Down