Repository navigation
The walk-note station says what it does - #44
Merged
Merged
Conversation
Its description is the tooltip the run graph shows on its node. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Lore is reviewing this PR — 612478f7-8406-49c9-9f47-ab2fa9a57120. Submit a review that requests changes to have Lore push a fix for it. Comment |
There was a problem hiding this comment.
Lore review — Approved
One-line description added; first sentence correct, second misattributes line context to the station; entity spec still missing the field
Must fix (0) · Consider (1) · Nits (1)
Reviewed by claude-sonnet-4-6
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Notes on lines outside changed hunks
docs/entities/station.md:35 — nit: Station definition table omits description — first real usage deserves a spec entry
Add a row to the field table: `| \`description\` | optional; one or two sentences for people reading the line; the floor stores it and acts on nothing in it; excluded from the version hash |`
Posted by floor, visit e425f95b-fa3c-486e-a411-fbdb359f34a2.
gedaiu
added a commit
that referenced
this pull request
Oct 12, 2026
The floor now refuses a line whose node has no edge for one of its station's outcomes, so 0002 as copied from #44 was refused with 400 at seed time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gedaiu
added a commit
that referenced
this pull request
Oct 12, 2026
* Walk-note's station description goes in a new migration file #44 edited scripts/pipelines/0001-walk-note.yaml after it had run, so every deploy since (v0.1.16) fails its pipeline-seed hook: migrate refuses a file that ran and was changed. 0001 is back to what ran (sha256 faf1ae9d..., matching the floor's record) and the description is 0002. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Walk-note line gets an edge for its failed outcome The floor now refuses a line whose node has no edge for one of its station's outcomes, so 0002 as copied from #44 was refused with 400 at seed time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Lore's run graph now shows each station's
descriptionas a tooltip on its node, and every station on the floor's assembly lines has one exceptwalk-note, the floor's own sample line.What Changed
scripts/pipelines/0001-walk-note.yaml: thewalk-notestation gains a description.Testing
floor-pipelinesConfigMap is a copy of this file. I'm updating it together with this change, so the next seed doesn't put the old text back. Since A reworded description reaches the version it belongs to #43, a seed refreshes a version's prose to whatever it is given.🤖 Generated with Claude Code