Repository navigation
A recipe watch that expires reopens quietly - #69
Merged
Merged
Conversation
The kube client ends every watch request after 30 seconds. The recipe watcher reopened it and logged each end as "the floor could not be reached", about 12,000 times in three days on internal-cluster, which read as the floor being down while it answered every claim. An expiry now reopens without a line, and a real drop says it is the recipe watch.
|
Lore is reviewing this PR — 46a3749d-b225-4c0a-876b-63964dd1da67. Submit a review that requests changes to have Lore push a fix for it. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kube client (v2) ends every watch request after 30 seconds with a TimeoutError.
watchRecipesreopened it and passed the error to the claim loop'sonError, which logs "the floor could not be reached; trying again". On internal-cluster that line appeared about 12,000 times in three days, one every 15 to 20 seconds from the two watches, while the claim loop reported "alive" every minute and the floor API answered in milliseconds.An expiry now reopens without a log line, and any other watch error is logged as "the recipe watch dropped; reopening".
isWatchExpiryis tested.🤖 Generated with Claude Code