Repository navigation
Pass an MCP server's secret-backed headers and env vars to the pod - #70
Merged
Merged
Conversation
A definition's mcp_servers kept only headers_secret, so a server that
wants X-API-Key, several headers, or a token in a stdio process's
environment could not be declared: the put dropped the fields. The
config schema now takes headers and env as {name, ref} lists, and the
brief carries them to the cluster agent, which hands them to the
subsystem (v0.15.0 reads both).
|
Lore is reviewing this PR — 02eee7f2-daac-40f0-91d0-5ecd6a341534. Submit a review that requests changes to have Lore push a fix for it. Comment |
There was a problem hiding this comment.
Lore review — Approved
Clean passthrough and validation of MCP server secret-backed headers and env vars across contracts, API config schema, cluster-agent recipe builder, and entity docs.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-4-argon
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Posted by floor, visit 719cc6f9-212c-4057-ab03-d101a073c79a.
gedaiu
added a commit
to re-cinq/lore
that referenced
this pull request
Nov 10, 2026
The agent edit page had no way to give an agent an MCP server; `config.mcp_servers` could only be set in the shipped md file. The org page (`/agents/edit/<name>`) and a repo's agent form now have an MCP servers section. Each server is a card of input fields: name, transport, a URL with an optional Authorization secret for http and sse, or a command with arguments for stdio, plus any number of headers (env vars for stdio) that each name a key of the cluster's `agent-secrets`. The API takes `mcp_servers` on create and update the same way it takes `pod_resources`: a list replaces the stored one, null removes it, an absent key keeps it. The form only submits the field once a row changed, so a save that never touched the servers leaves the floor's list alone and a repo's page does not copy the org default's servers into its variant. `PodResourcesWrite` became `ConfigWrite`, since it now carries two config keys. A refused write shows its first validation issue on the form. `headers` and `env` need re-cinq/floor#70 deployed: until then the floor drops those two fields and Lore's read-back check fails the save. Servers that use only a URL, a command or `headers_secret` work on today's floor. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An agent definition's
mcp_serverscould only name one secret,headers_secret, sent as the Authorization header. The subsystem (v0.15.0, already vendored here) also readsheadersfor http and sse servers andenvfor stdio servers, each a list of{name, ref}valued fromagent-secrets. The config schema silently dropped both on put.The schema now accepts them and refuses an entry without a
ref. They travel in the brief's settings to the cluster agent, which already spreads a server's fields into the AgentDefinition.ExecutorSettingsin the API was a copy of the contracts type and is now imported from there.Lore's agent edit form will offer these fields next; it needs this deployed first, because Lore reads a definition back after every put and fails when a field was dropped.
🤖 Generated with Claude Code