Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

zrange min->start max ->stop - #1736

Merged
itamarhaber merged 6 commits into
redis:masterfrom
slorello89:zrange-minmax-to-startstop
Jan 24, 2022
Merged

itamarhaber merged 6 commits into
redis:masterfrom
slorello89:zrange-minmax-to-startstop

Conversation

@slorello89

Copy link
Copy Markdown
Member

Accompanying PR to redis/redis#10097 to change min -> start and max -> stop in ZRANGE see other PR for explanation for change.

@slorello89

Copy link
Copy Markdown
Member Author

@itamarhaber

@zuiderkwast zuiderkwast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

Is it explained somewhere that REV needs start=max and stop=min? Maybe add that somewhere...

It would be good to add an example with REV as well.

Comment thread commands.json
Comment thread commands/zrange.md
Comment thread commands/zrange.md Outdated
slorello89 and others added 2 commits January 11, 2022 09:20
Co-authored-by: Viktor Söderqvist <viktor@zuiderkwast.se>
@slorello89

Copy link
Copy Markdown
Member Author

@zuiderkwast - added another piece about the REV argument.

@zuiderkwast zuiderkwast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added section about reverse ranges explains it very well.

Question: Does BYLEX REV also reverse the start and stop lexicographic order?

Comment thread commands/zrange.md Outdated
Comment thread commands/zrange.md Outdated
@slorello89

Copy link
Copy Markdown
Member Author

@zuiderkwast - added the bit on BYLEX also addressed the couple stylistic things you pointed out. Did I miss something? I don't see a CONTRIBUTING.md in this repo.

@zuiderkwast

Copy link
Copy Markdown
Contributor

@zuiderkwast - added the bit on BYLEX also addressed the couple stylistic things you pointed out. Did I miss something? I don't see a CONTRIBUTING.md in this repo.

Sorry, it's in the readme: https://github.com/redis/redis-doc#styling-guidelines

No need to add a blank line which will cause a new paragraph. A single linebreak in the markdown is enough and it doesn't cause any linebreak in the rendered HTML. The purpose is just to make the diff smaller when some part of the text is changed, i.e. easier to review changes.

Comment thread commands/zrange.md
Comment thread commands/zrange.md
@zuiderkwast

Copy link
Copy Markdown
Contributor

The build error is the spellcheck which doesn't like the word BYLEX. If the code example is surrounded by backticks I think it can escape the spell check. Otherwise, we need it to the wordlist file.

@slorello89

Copy link
Copy Markdown
Member Author

Gotcha - I guess that command snippet should not have been bolded, I guess aspell automatically knows not to boot out command names? Regardless, I pushed the updates requested.

@itamarhaber
itamarhaber merged commit 8bd9e39 into redis:master Jan 24, 2022
pchmielewski added a commit to pchmielewski/redis-doc that referenced this pull request Feb 9, 2022
In redis#1736 there were introduced new names of parameters 'min', 'max' (now 'start', 'stop'), but command in header wasn't updated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants