Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates pinned Git revisions for Iceberg and ChangesDependency revisions and benchmark configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Forward-port #26990 to RisingWave main. COW publication should prune obsolete deletion-only manifests and merge small data manifests during the existing overwrite commit, preventing metadata growth while the live file set stays small.
Update the pinned dependencies to iceberg-rust#234, commit
54d7ddc4565254fb284d0199edd0f8d331d0e3f9, and a compaction pin-alignment commit. Both are based on the exact dependencies already used by RisingWave main; no unrelated upstream dependency changes are pulled in. The lockfile changes only these two Git revisions and resolves a single Iceberg source.Main's Iceberg dependency line no longer contains the old inline merge implementation, so the dependency patch adapts it into one private snapshot-producer helper. It retains the 8 MiB target / 100-manifest first-bin threshold, groups by partition spec, preserves original entry sequences and the current commit's added/deleted entries, and honors explicit property overrides. It adds no extra snapshot or data-file rewrite. No tests or V3-specific handling are added.
Validation:
RUSTUP_TOOLCHAIN=nightly-2026-03-05 make checkpasses.CXXFLAGS='-include cerrno' cargo +nightly-2026-06-21 check -p risingwave_storage --lib --lockedpasses. The local C++ flag supplies a missing FAISS header and is not part of the source change.Checklist
Documentation
Release note
Reduce Iceberg copy-on-write manifest accumulation and metadata overhead during publication.
Summary by CodeRabbit