Conversation
mctang24
force-pushed
the
fix-queue-update-after-run
branch
3 times, most recently
from
August 20, 2026 13:56
de1a9c7 to
045d9e1
Compare
mctang24
force-pushed
the
fix-queue-update-after-run
branch
from
August 20, 2026 14:05
045d9e1 to
a3316ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1163.\n\nQueueUpdate now returns without invoking its callback when the application is not running or the event loop stops before the callback runs. While Run is active, QueueUpdate still waits for the callback to execute.\n\nSync now uses QueueUpdate and follows the same shutdown behavior.\n\nThe added regression test posts a tcell EventError, waits for Run to return, and verifies that QueueUpdate does not block.\n\nVerified with go test ./..., go test -race ./..., and the regression test repeated 100 times.