This repository was archived by the owner on Dec 3, 2020. It is now read-only.
Python 2 and 3 compat, no additional dependancies#9
Open
ksamuel wants to merge 4 commits intorkern:masterfrom
Open
Python 2 and 3 compat, no additional dependancies#9ksamuel wants to merge 4 commits intorkern:masterfrom
ksamuel wants to merge 4 commits intorkern:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 2 is reaching EOL in 2 months, and grin is stuck in V2 right now.
I noticed that the PR #4 never got merged. I thought that maybe it was because it was depending on python-future or was trying to do too much with the travis support.
So I made this PR that makes grin support python 2 and python 3 with one code base. It doesn't require any effort or change on your part:
If that's OK for you, you can merge it, and upload it on pypi. You don't even need to add me as a contributor.