This repository was archived by the owner on Dec 3, 2020. It is now read-only.
Python 3 support#1
Closed
jvkersch wants to merge 2 commits into
Closed
Conversation
added 2 commits
January 22, 2016 15:41
rsalmaso
added a commit
to rsalmaso/grin3
that referenced
this pull request
Apr 19, 2017
|
Hey @jvkersch : sorry to bug you. Why did you close your python3 PR? Do you know what the plan is to push a Py3 upgrade or another? |
Owner
Author
|
Like Robert, I've moved on to use ripgrep. |
|
Thank you both for responding. RIP grin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Python 3 support to Grin. Perhaps the most non-trivial aspect is that under Python 3 this assumes that strings are encoded as UTF-8. This may not be what the user always wants, and it makes Grin under Python 3 a little more fragile (e.g. grinning a file with mixed ASCII/binary data is problematic).