Skip to content

Changed the graphic design to look more actual - #98

Open
rocboronat wants to merge 5 commits into
rockerhieu:masterfrom
rocboronat:master
Open

rocboronat wants to merge 5 commits into
rockerhieu:masterfrom
rocboronat:master

Conversation

@rocboronat

Copy link
Copy Markdown

Hi! In order to look like the common apps with emojis like Telegram, Hangouts or Whatsapp, we changed some things:

  • By default, the background of the Fragment is like the official Google Keyboard, instead of an holo gradient.
  • Instead of using alpha to show the selected tab, we're going to tint the picture of the ImageButton. In addition, the apps can define that colours using another newInstance() method. By default, the selected tab will be the common Material Design blue.
  • The emojicons.xml is based in a vertical LinearLayout to improve readability. (sorry about the whole code formatting! Please, ignore the white lines while comparing it)
  • The vertical dividers of the tabs have now disappeared, to meet the last emojicon keyboards style.
  • The minSDK is 8 instead of 7, to support the ImageButton tinting

@rocboronat

Copy link
Copy Markdown
Author

A picture is worth a thousand words! :·)

2015-12-13 19 57 26

@rockerhieu

Copy link
Copy Markdown
Owner

Can you rebase your branch?

@rockerhieu

Copy link
Copy Markdown
Owner

I think we should support customizing theme for this.

Conflicts:
	emojicon.iml
	example/example.iml
	library/library.iml
	library/src/main/java/com/rockerhieu/emojicon/EmojiconsFragment.java
	library/src/main/res/drawable/ic_emoji_nature_light.xml
	library/src/main/res/drawable/ic_emoji_objects_light.xml
	library/src/main/res/drawable/ic_emoji_people_light.xml
	library/src/main/res/drawable/ic_emoji_places_light.xml
	library/src/main/res/drawable/ic_emoji_recent_light.xml
	library/src/main/res/drawable/ic_emoji_symbols_light.xml
	library/src/main/res/layout/emojicons.xml
	library/src/main/res/values/colors.xml
@rocboronat

Copy link
Copy Markdown
Author

@rockerhieu done! :·) Someone did a big reformat of the code, didn't it? 👍

@rocboronat

Copy link
Copy Markdown
Author

@rockerhieu about theming it, for sure it could be a great feature. Right now we did the minimum version to give value to the developer :·) (in this case, us, hehe!)

@gabrielgatu

Copy link
Copy Markdown

Hi! I am using the 1.3.3 version right now, with gradle, but the theme for the EmojiconsFragment (instantiated with .newInstance(false)) doesn't look like the one that you posted (Still looks like the 1.0 one, but with a dark background - I assume that should have the same color as my keyboard, which is white - default of android 6.0).
Maybe the theme it's implemented in version 1.3.4?

Thank you for this amazing library btw ^_^

@vanniktech

Copy link
Copy Markdown

👍 this looks really better

@rocboronat

Copy link
Copy Markdown
Author

Thanks @vanniktech :)

@vanniktech

Copy link
Copy Markdown

@rocboronat since this has gone very stale (overall the project) and I had some free time I made a fork out of an earlier version of this library: https://github.com/vanniktech/Emoji

Has some new emojis and their categories and also an implementation of Recent Emojis

@rocboronat

Copy link
Copy Markdown
Author

Thanks @vanniktech! Just read it, two years later 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants